1128930 - mozilla::Array does not allow aggregate initializers

Status: REOPENED

(Core :: MFBT, defect)

Description

[Masatoshi Kimura [:emk]]

Attachment: patch

Because mArr is private.

Comment 1

[Jeff Walden [:Waldo]]

Comment on attachment 8558495 [details] [diff] [review]
patch

Review of attachment 8558495 [details] [diff] [review]:
-----------------------------------------------------------------

::: mfbt/Array.h
@@ +24,1 @@
>    T mArr[Length];

Interesting, I didn't know this was a requirement to use aggregates.  :-(

I guess specs deal with this must-be-public requirement by using a reserved name.  We can't do that ourselves because, well, we're not implementing the language.  So let's at least rename this a bit to make clearer that this is Not To Be Touched.  Could you rename this to |mPrivateArrFieldDoNotUse|?  Or something that makes clear people must not use this directly.

Comment 2

[Masatoshi Kimura [:emk]]

I found our portability guide did not allow to use initializer lists with objects :(
https://developer.mozilla.org/en-US/docs/Mozilla/C++_Portability_Guide#Don%27t_use_initializer_lists_with_objects
It would be better to enforce the restriction until the guide is reconsidered. Luckily, mozilla::BinarySearchIf worked with plain arrays.

Comment 3

[Jeff Walden [:Waldo]]

I'm pretty sure our style guide is Just Wrong there, because it's unbearably ancient on the point.  Certainly HP-UX we don't care about that much -- it better be using supported gcc and such, and I doubt there's a portability concern for such gcc on HP-UX.