1129016 - Investigate failure in test_settings_do_not_track.py

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Viorela Ioia [:viorela]]

Test test_settings_do_not_track.py is failing on latest m-c: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk-319.mozilla-central.ui.functional.non-smoke.1/172/HTML_Report/
I've been able to reproduce the failure locally, the test is failing intermittently; repro rate: 4/5
Probably we should add a better wait, before checking if the pref is True/False.  

Traceback (most recent call last):
File "/var/jenkins/1/workspace/flame-kk-319.mozilla-central.ui.functional.non-smoke.1/.env/local/lib/python2.7/site-packages/marionette_client-0.8.7-py2.7.egg/marionette/marionette_test.py", line 283, in run
testMethod()
File "/var/jenkins/1/workspace/flame-kk-319.mozilla-central.ui.functional.non-smoke.1/tests/python/gaia-ui-tests/gaiatest/tests/functional/settings/test_settings_do_not_track.py", line 33, in test_enable_do_not_track_via_settings_app
self.assertEqual(self.data_layer.get_bool_pref('privacy.donottrackheader.enabled'), True)
AssertionError: False != True

Device firmware (base) 	L1TC100118D0
Device firmware (date) 	03 Feb 2015 06:16:28
Device firmware (incremental) 	eng.cltbld.20150203.091617
Device firmware (release) 	4.4.2
Device identifier 	flame
Gaia date 	02 Feb 2015 11:50:21
Gaia revision 	ae5a1580da94
Gecko build 	20150203052826
Gecko revision 	b28f97ae095a
Gecko version 	38.0a1

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Before https://github.com/mozilla-b2g/gaia/commit/a0529167d625c8a99d58ff249b12b98bd2aff973 the app object waited for both prefs. I modified it to wait for the UI cues but this didn't appear to be enough for the int pref, and apparently is sometimes not enough for the boolean also. We could just change the assert to a wait in the test.

Comment 2

[GitHub Autolander Bot]

Attachment: [PullReq] viorelaioia:bug_bug_1129016 to mozilla-b2g:master

Comment 3

[Florin Strugariu [:Bebe]]

https://github.com/mozilla-b2g/gaia/commit/70922d07e1de10aea3381aa954add71ce75c2e2d

Comment 4

[GitHub Autolander Bot]

Attachment: [PullReq] viorelaioia:revert_commit_591d5a to mozilla-b2g:master

Comment 5

[GitHub Autolander Bot]

Attachment: [PullReq] viorelaioia:bug_1129016_1 to mozilla-b2g:master

Comment 6

[Florin Strugariu [:Bebe]]

https://github.com/mozilla-b2g/gaia/commit/a988dd76dc649bd91f7d88beb753fbd27a65b3ac