1129164 - Disable failing mulet mochitests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Runtime, defect)

Description

[Gregor Wagner [:gwagner]]

We want to unhide the test suite.

Comment 1

[Gregor Wagner [:gwagner]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=60a6a8b5cfd2

Comment 2

[Gregor Wagner [:gwagner]]

Attachment: 1129164.diff

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8558761 [details] [diff] [review]
1129164.diff

Review of attachment 8558761 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/test/mochitest.ini
@@ +169,5 @@
>  [test_url.html]
>  [test_urlApi.html]
>  [test_workersDisabled.html]
>  [test_worker_interfaces.html]
> +skip-if = buildapp == 'mulet'

This one is too important to just disable. We need to figure out what mulet is giving for these values and fix it to think b2g == true on mulet:

http://mxr.mozilla.org/mozilla-central/source/dom/workers/test/test_worker_interfaces.js?force=1#174

Then it should all work.

Comment 4

[:gerard-majax]

Given bug 1129849 and its dependencies, we should be good to update this path to remove the disabling of worker_interfaces and get green after this. The remaining errors I see on mochitest 4 for Mulet on https://treeherder.mozilla.org/#/jobs?repo=try&revision=20fcc0c2a17b&exclusion_profile=false are the tests skipped in this patch.

Comment 5

[:gerard-majax]

Attachment: Disable some failing mochitests on mulet r=bent

Comment 6

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d62c5e7ffbc6

Comment 7

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8563390 [details] [diff] [review]
Disable some failing mochitests on mulet r=bent

Review of attachment 8563390 [details] [diff] [review]:
-----------------------------------------------------------------

Ok, the patch is broken, but r+ with it fixed:

::: embedding/test/mochitest.ini
@@ +8,5 @@
>  [test_nsFind.html]
>  [test_private_window_from_content.html]
>  # Next two tests are disabled in e10s because of bug 989501.
>  [test_window_open_position_constraint.html]
> +skip-if = toolkit == 'android' || e10s || 'mulet'

Hm, this looks wrong. Won't this disable everywhere since 'mulet' will evaluate to True? You want |buildapp == 'mulet'|

Comment 8

[:gerard-majax]

Attachment: Disable some failing mochitests on mulet r=bent

Comment 9

[:gerard-majax]

Comment on attachment 8563949 [details] [diff] [review]
Disable some failing mochitests on mulet r=bent

Carrying r+

Comment 10

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0bb7e101133b

Comment 11

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d144b06dbabc

Comment 12

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #11)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=d144b06dbabc

Green for mulet mochitests 1, 2, 3, 4, and 5 \o/

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/b2g-inbound/rev/4af25f297091

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4af25f297091