1129169 - Country Selection broken if more than one provider exists for a region

Status: VERIFIED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P2)

Description

[David Bialer [:dbialer]]

Attachment: payment screen.png

When I submit a paid app, I am only seeing choices for Greece, Germany, Colombia and Spain.  What happened to other countries such as Mexico, US, UK?

Comment 1

[Andy McKay]

What server is this on?

Comment 2

[David Bialer [:dbialer]]

production.

Comment 3

[David Bialer [:dbialer]]

also notice in the screenshot, next to greece it says it is available for All Bango twice.

Comment 4

[Andy McKay]

Looks like there are too many price currencies in the db, I'll get those cleared out. But I'm not sure why they aren't all being listed, muffinresearch do you know why?

Comment 5

[Andy McKay]

Cleaning out the price currency did it.

Comment 6

[Andy McKay]

Although this is fixed on prod, I think its going to hit us when Boku goes live.

https://marketplace.allizom.org/developers/app/compound-interest/payments/

Here's an app on stage on price tier 1:

https://www.dropbox.com/s/dsqqcyzog2ru9p1/Screenshot%202015-02-03%2016.49.26.png?dl=0

Here's the api call on stage:


[master] zamboni $ curl -s https://marketplace.allizom.org/api/v1/webpay/prices/1/ | python -m json.tool | grep region
        "region": "Rest of World",
            "region": 9,
            "region": 8,
            "region": 14,
            "region": 17,
            "region": 4,
            "region": 13,
            "region": 12,
            "region": 12,
            "region": 11,
            "region": 1,
            "region": 2,
            "region": 7,
            "region": 10,
            "region": 18,
            "region": 19,
            "region": 23,
            "region": 31,
            "region": 37,

Note that region 1 (Rest of the World) doesn't show up. My guess is that its because there are two prices for Mexico.

I changed the price to be 24.99, a price that doesn't occur for Boku and note that all the regions show up:

https://www.dropbox.com/s/e21qp0nawo2nz0o/Screenshot%202015-02-03%2016.51.45.png?dl=0

So I think something is going wrong in that loop. You should be able to recreate this Stuart by adding price tiers for boku, just add in a price currency row for an already existing country, but change the provider to be boku.

Comment 7

[[e-mail]]

Yep, the problem was we're bailing out of the loop too early. 

PR: https://github.com/mozilla/zamboni/pull/2889

Comment 8

[[e-mail]]

https://github.com/mozilla/zamboni/commit/7da16823bced59c2aa376c73090c1ec31002aca3

Comment 9

[Madalin Cotetiu]

Verified as fixed in FF38(Win7) in marketplace-dev.allizom.org
Postfix screencast: http://screencast.com/t/VrsmSqqQr
Closing bug.