1129181 - Make Remote Tabs home panel split pane pull to refresh apply to the whole page, not just the tabs

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Nick Alexander :nalexander [he/him]]

Right now, in landscape tablets, only the list of remote tabs has pull to refresh.  There are some limitations here from the GeckoSwipeRefreshLayout.  Can we make the whole panel pull to refresh?

Comment 1

[Nick Alexander :nalexander [he/him]]

I'd like this to track Fennec 38.

Comment 2

[Vivek Balakrishnan[:vivek]]

Attachment: 1129181.patch

Linear layout moved inside GeckoSwipeRefreshLayout, now entire view (clients and tabs) can be pulled to refresh

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8562991 [details] [diff] [review]
1129181.patch

Review of attachment 8562991 [details] [diff] [review]:
-----------------------------------------------------------------

This doesn't work all that well on one of my test tablets, but it's not really us: GeckoSwipeRefreshLayout doesn't delegate all drags to the children correctly.  To test this, make sure you have lots of tabs for one device, so that you can scroll the list.

I'm going to land this anyway, since it's closer to what we want.

::: mobile/android/base/resources/layout/home_remote_tabs_split_plane_panel.xml
@@ +41,2 @@
>  
>          </org.mozilla.gecko.widget.GeckoSwipeRefreshLayout>

nit: outdent here.

Comment 4

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/7fd767f1b043

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7fd767f1b043