1129186 - [RTL][Homescreen] The lower left side of the homescreen app groupings does not react correctly when attempting to open the homescreen settings menu or move icons into this area.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect, P1)

Description

[Joshua Mitchell (Inactive)]

Attachment: logcat_20150203_1431.txt

Description:
In RTL languages, the homescreen will align icons on the right side of the screen first. This causes the 'open space' to be at the bottom left of app groupings. This open space seems to be unresponsive to touch events. If you long press on the open space of an app group you do not get the long-press contextual menu. If you try to drag an icon to this area, it will have great difficulty adding it to that section and usually instead adds it to the group below 
These symptoms do not reproduce when using a minimized app grouping.

Repro Steps:
1) Update a Flame to 20150203055641 and set language to an RTL language (ex: Arabic)
2) Create an app-grouping of 4 apps (to better see the bug)
3) long press on the open area of that app group
4) Attempt to move an icon from a different app group into the open area of the test group

Actual:
Bottom left section of app-groups are unresponsive to touch events

Expected:Bottom left section of app-groups will be responsive and operate normally

Environmental Variables:
Device: Flame 3.0
Build ID: 20150203055641
Gaia: ae5a1580da948c3b9f93528146b007fc4f6a712b
Gecko: ae5d04409cd9
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Repro frequency: 8/9
See attached: logcat, video: http://youtu.be/Sh7VZ-PEXC8

-------------------------------------------------------------------------------------
This issue DOES reproduce in 2.2 

Device: Flame 2.2 (KK - Nightly - Full Flash)
Build ID: 20150202002507
Gaia: d6141fa3208f224393269e17c39d1fe53b7e6a05
Gecko: be206fa2fb60
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18d-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 1

[Dylan Oliver [:doliver]]

triage: P1 for impact on functionality. This really hinders the usage of the homescreen as it is very difficult to arrange icons the way you want and tricky to trigger the long press to access settings/wallpaper options.

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

Chris, could you take a look here?

Comment 3

[Chris Lord [:cwiiis]]

Can reproduce, having a look.

Comment 4

[Chris Lord [:cwiiis]]

Think this is caused by placeholders not being in the right place for expanded groups.

Comment 5

[GitHub Autolander Bot]

Attachment: [PullReq] Cwiiis:bug1129186-homescreen-rtl-placeholders to mozilla-b2g:master

Comment 6

[Chris Lord [:cwiiis]]

Comment on attachment 8561450 [details] [review]
[PullReq] Cwiiis:bug1129186-homescreen-rtl-placeholders to mozilla-b2g:master

This is my fault, I should have caught this when I reviewed the initial RTL patch. Either way, small fix.

Not included a test, as this would have been caught if tests were run in RTL, and I think we already have a bug for that?

(the precedent being that if I wrote a test for this, we'd have to have duplicate tests for all homescreen features in RTL)

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 8561450 [details] [review]
[PullReq] Cwiiis:bug1129186-homescreen-rtl-placeholders to mozilla-b2g:master

I hope we don't break this in the future. Thanks for the fix!

Comment 8

[Chris Lord [:cwiiis]]

Merged: https://github.com/mozilla-b2g/gaia/commit/170d093483cbdb4c7f27b620f68a822f42e76f98

Comment 9

[Chris Lord [:cwiiis]]

Comment on attachment 8561450 [details] [review]
[PullReq] Cwiiis:bug1129186-homescreen-rtl-placeholders to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Hard to get to homescreen context menu in RTL locales
[Testing completed]: Tested manually
[Risk to taking this patch] (and alternatives if risky): None that I can discern
[String changes made]: None

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/bbb232cc458143f70cfd8302e38eb45b8425b0a7

Comment 11

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue is verified fixed on Flame 3.0

The user is able to long press on the left side of an empty expanded group space to call the homescreen settings context menu. The user is also able to properly arrange apps within, or add to a group without issue. The left side of app groups are responsive and behaving as intended.

Environmental Variables:
Device: Flame 3.0 (319mb)(Kitkat)(Full Flash)
Build ID: 20150211010216
Gaia: 8c7865486a1b11076b849bbf8f7fccbaffbfafe7
Gecko: ee093ca70666
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0
---------------------------------------------------------------------------------------------
adding verifyme keyword for this issue to be verified on 2.2

Comment 12

[Coler]

This issue has been verified successfully on Flame 2.2.
Reproduce rate:0/5
Attachment:Verify_RTL_Smartconnection.mp4

Flame 2.2 build:

Gaia-Rev        791e53728cd8018f1d7cf7efe06bbeb1179f0370
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5dec207fcbeb
Build-ID        20150212002504
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150212.042208
FW-Date         Thu Feb 12 04:22:18 EST 2015
Bootloader      L1TC000118D0

Comment 13

[Coler]

Attachment: Verify_RTL_Smartconnection.MP4