Closed Bug 1129277 Opened 5 years ago Closed 5 years ago
Remove "builtinclass" interface attribute from ns
IMobile Connection Callback
Let me ask the expert. :) Hi Kyle, If I change the idl interface attribute "builtinclass", will it affect the binary compatibility?
No, it doesn't change the binary compatibility, so you don't need to change the IID. But you should make sure that we don't static_cast an nsIFoo to the concrete implementation type, because that is unsafe without 'builtinclass'. Bonus points if you update MDN ;)
Comment on attachment 8564880 [details] [diff] [review] Remove builtinclass of nsIMobileConnectionCallback Bug caused by (feature/regressing bug #): Bug 1067629 need this patch User impact if declined: Bug 1067629 cannot be uplifted Testing completed: NA Risk to taking this patch (and alternatives if risky): NA String or UUID changes made by this patch: NA
Attachment #8564880 - Flags: approval-mozilla-b2g37?
The try server result is tested with the 2.2 patches of bug 1067629. https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c653bab7ec9&exclusion_profile=false
Attachment #8564880 - Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
You need to log in before you can comment on or make changes to this bug.