1129277 - Remove "builtinclass" interface attribute from nsIMobileConnectionCallback

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Szu-Yu Chen [:aknow] (inactive)]

"builtinclass" means

"""
JavaScript classes are forbidden from implementing this interface.
"""

Most of the methods in nsIMobileConnection require a nsIMobileConnectionCallback.  If it is not allowed to be implemented in JavaScript, that means other services like GonkTelephonyService which we wrote in JavaScript is not possible to use those method.

For me, it's not reasonable and I'd like to change it.  The only problem is that I'm not really sure whether it will affect our locked down interface or not.  If the new interface remains the same binary compatibility, we are okay to do it.

The MDN document lists some attributes and tell whether they affect the binary compatibility [1].  But, "builtinclass" is not in the list so I am not sure about it.

[1] https://developer.mozilla.org/en-US/docs/Mozilla/XPIDL#Source_and_Binary_Compatibility

Comment 1

[Szu-Yu Chen [:aknow] (inactive)]

Let me ask the expert. :)

Hi Kyle,

If I change the idl interface attribute "builtinclass", will it affect the binary compatibility?

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

No, it doesn't change the binary compatibility, so you don't need to change the IID.  But you should make sure that we don't static_cast an nsIFoo to the concrete implementation type, because that is unsafe without 'builtinclass'.

Bonus points if you update MDN ;)

Comment 3

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Remove builtinclass of nsIMobileConnectionCallback

Comment 4

[Szu-Yu Chen [:aknow] (inactive)]

try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=38bd2b653b92&exclusion_state=all

Comment 5

[Szu-Yu Chen [:aknow] (inactive)]

https://hg.mozilla.org/integration/b2g-inbound/rev/42625647394f

Comment 6

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/mozilla-central/rev/42625647394f

Comment 7

[Ben Hsu [:HoPang]]

Comment on attachment 8564880 [details] [diff] [review]
Remove builtinclass of nsIMobileConnectionCallback

Bug caused by (feature/regressing bug #): Bug 1067629 need this patch
User impact if declined: Bug 1067629 cannot be uplifted
Testing completed: NA
Risk to taking this patch (and alternatives if risky): NA
String or UUID changes made by this patch: NA

Comment 8

[Ben Hsu [:HoPang]]

The try server result is tested with the 2.2 patches of bug 1067629.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c653bab7ec9&exclusion_profile=false

Comment 9

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/18d1063ae81d