Closed Bug 1129317 Opened 5 years ago Closed 5 years ago

SystemMessageInternal 1423035594631 : Unknown pendingPromise messageID. This seems a bug!!

Categories

(Core :: DOM: Device Interfaces, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: kanru, Assigned: baku)

Details

Attachments

(1 file, 1 obsolete file)

While debugging bug 1126119 I found these error messages

I/Gecko   ( 3083): -- SystemMessageInternal 1423035594464 : received SystemMessageManager:GetPendingMessages activity for app://gallery.gaiamobile.org/index.html#pick @ app://gallery.gaiamobile.org/manifest.webapp
I/Gecko   ( 3083): -- SystemMessageInternal 1423035594631 : received SystemMessageManager:HandleMessageDone activity with msgID undefined for app://gallery.gaiamobile.org/index.html#pick @ app://gallery.gaiamobile.org/manifest.webapp - promise rejected: false
I/Gecko   ( 3083): -- SystemMessageInternal 1423035594631 : Unknown pendingPromise messageID. This seems a bug!!

Which seems caused by http://mxr.mozilla.org/mozilla-central/source/dom/messages/SystemMessageInternal.js?rev=f15ef701bdf2#500

I'm not sure if this is real issue. fabrice?
Flags: needinfo?(fabrice)
That's from baku's latest changes (see http://mxr.mozilla.org/mozilla-central/source/dom/messages/SystemMessageInternal.js?rev=f15ef701bdf2#785)

Andrea? "This seems a bug!!"
Flags: needinfo?(fabrice) → needinfo?(amarchesini)
kanru, can you reproduce this issue 100% of the times?
Do you have a small test I can use it?
Flags: needinfo?(amarchesini) → needinfo?(kchen)
I could reproduce it 100% of the times. Just uncomment the debug function in SystemMessageInternal.js and launch any app with activity. For example, I long tap the homescreen background and choose the Gallery app to choose background.
Flags: needinfo?(kchen)
Assignee: nobody → amarchesini
Attached patch id.patch (obsolete) — Splinter Review
We need the msgID also when the GetPendingMessages is called.
It doesn't seem that the messageID is used anywhere else, so it should not be a problem to keep it and send it to the child.
Attachment #8560425 - Flags: review?(fabrice)
Attachment #8560425 - Flags: review?(fabrice) → review+
Attached patch id.patchSplinter Review
https://treeherder.mozilla.org/#/jobs?repo=try&revision=11d06a2a6747

If green, checkin-needed.
Attachment #8560425 - Attachment is obsolete: true
Keywords: checkin-needed
Andrea, the latest patch seems to contain unintended modifications to Blob.cpp
Flags: needinfo?(amarchesini)
Keywords: checkin-needed
Yeah... I did mix 2 patches in one. Here the new try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e5531980e4d
I'll mark this bug checkin-needed if this is fully green.
Flags: needinfo?(amarchesini)
https://hg.mozilla.org/mozilla-central/rev/7accb67a2e6f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.