1129325 - Remove nonstandard let blocks from dom

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: dom.patch

let blocks are a nonstandard SpiderMonkey feature we would like to remove (in bug 1023609). This patch removes the let blocks in the dom/ subtree. For variable names that are declared in multiple let blocks in the same function, I just reused the same variable instead of giving them pointlessly unique names like `str2`.

The attached patch excludes whitespace changes because most of the patch is unindenting blocks of unchanged code from the removed let blocks. This made the important bits of the patch harder to review.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8558984 [details] [diff] [review]
dom.patch

Review of attachment 8558984 [details] [diff] [review]:
-----------------------------------------------------------------

In the future it'd be good to attach both the diff -w as well as the full diff. This looks good to me.

Comment 2

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f27d90cb3907

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f27d90cb3907