Closed
Bug 1129326
Opened 10 years ago
Closed 10 years ago
Remove nonstandard let block from memory/replace/dmd/test/test_dmd.js
Categories
(Core :: Memory Allocator, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
Tracking | Status | |
---|---|---|
firefox38 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
1.78 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
let blocks are a nonstandard SpiderMonkey feature we would like to remove (in bug 1023609). This patch removes a let block in the memory/ subtree.
Attachment #8558985 -
Flags: review?(n.nethercote)
![]() |
||
Comment 1•10 years ago
|
||
Comment on attachment 8558985 [details] [diff] [review]
memory.patch
Review of attachment 8558985 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks. Bonus points if you convert the three |var| occurrences in that file to |let|, for consistency.
Attachment #8558985 -
Flags: review?(n.nethercote) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Thanks. I changed the vars to lets, too.
https://hg.mozilla.org/integration/mozilla-inbound/rev/dba1aedcb961
Comment 3•10 years ago
|
||
Assignee: nobody → cpeterson
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•