1129385 - [Loop][Telemetry] Wrong notifications sharing one room created without subject, and added subject before sharing it.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Javier de Prado]

ENV:
FireE v2.0 comercial version
Loop version 1.1.1/d4d66d37

STR:
1.- Create new room without subject and save it.
2.- Edit room, and add subject.
3.- Share the room (via email and sms)

ACTUAL RESULT:
"smsNotification":{"1":1},"smsNotificationWithSubject":{"0":1},"emailNotification":{"1":1},"emailNotificationWithSubject":{"0":1}

EXPECTED RESULT:
"smsNotification":{"0":1},"smsNotificationWithSubject":{"1":1},"emailNotification":{"0":1},"emailNotificationWithSubject":{"1":1}

Comment 1

[Oscar Patiño González]

Attachment: proposed patch

Comment 2

[Carmen Jimenez Cabezas]

I have re-checked this with the product team and the current behavior is the expected one. What the product team wants to know is the number of rooms shared that had or had not subject when they were created (not when they were shared). And that's what it's currently doing, so this bug is not really a bug.

Comment 3

[Carmen Jimenez Cabezas]

After talking with the product team again, they changed their mind and so the bug is a valid one after all.

Comment 4

[Carmen Jimenez Cabezas]

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/8c745841036d789a243b3345dabbc2ce970ada6d

Comment 5

[Maria Angeles Oteo (:oteo)]

Giving the approval to uplift it to 1.1.1 branch,
Carmen or Oscar (the first one that reads this), could you please include the fix in 1.1.1 branch?
Thanks a lot!

Comment 6

[Carmen Jimenez Cabezas]

Uplift commit:
https://github.com/mozilla-b2g/firefoxos-loop-client/commit/7b17e40a84e0dd8fa59e3f51c81d6eb38ab2dac3

Comment 7

[Javier de Prado]

Verified on fireE, v2.0 comercial version
Loop app version 1.1.1/253ebde