1129401 - Can't copy URL by right click it the first time

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Greve Kenne]

Attachment: Context menu "Cut", "Copy" and "Delete" are disabled.

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20150122214805

Steps to reproduce:

1. Right Click Awesome Bar.


Actual results:

"Cut", "Copy" and "Delete" in the context menu are disabled.


Expected results:

"Cut", "Copy" and "Delete" in context menu should have been enabled.

Comment 1

[Greve Kenne]

If this is a feature, then please provide an option such as a check box or in "about:config" to enable the commands "Cut", "Copy" and "Delete" in the context menu after right click the Awesome Bar the first time.

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

If you're not selected anything, there's nothing to cut, copy or delete
or I'm missing something?

Comment 5

[Greve Kenne]

(In reply to Virtual_ManPL [:Virtual] from comment #2)
> If you're not selected anything, there's nothing to cut, copy or delete
> or I'm missing something?

You don't have to select anything, as mentioned in the single "Step to reproduce" in this page, just try to right click the "Location Bar" (URL Bar), that will result in highlighting (selecting) the entire URL and showing a context menu same as the one in the attachments (find attached image in this page, name "Context menu "Cut", "Copy" and "Delete" are disabled."). If you do this on Windows, then the results will end up fine and all the commands will be enabled such as "Undo", "Cut", "Copy", "Paste", ... etc., but if you do this (right click the "Location Bar" (URL Bar)) on Mac, then the results will be a context menu with "Cut", "Copy" and "Delete" are disabled same as the one in the attachments (find attached image in this page, name "Context menu "Cut", "Copy" and "Delete" are disabled."). I hope this explanation will make it clear, just try "Steps to reproduce" in this page.

Comment 6

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Can you also reproduce it with clean fresh new Firefox profile without any addons and plugins?

Comment 7

[Greve Kenne]

(In reply to Virtual_ManPL [:Virtual] from comment #6)
> Can you also reproduce it with clean fresh new Firefox profile without any
> addons and plugins?

Yes, I've tested this on new MacBook Pro, fresh new Firefox, but it's the same.

This issue started on Firefox version 35.0, and still happening on beta versions, I've tested this on the latest Firefox beta version 36.0b8 released hours ago on 10-Feb-2015 02:23 (fresh new Firefox tested on a new Mac).

I've downgraded to previous versions of Firefox versions 34.0.5 and 34.0 and it's working as it should on both previous versions (the issue doesn't happen on Firefox versions 34.0.5 and 34.0, it works fine on Firefox versions 34.0.5 and 34.0).

Comment 8

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

If you can, you may try finding a regression range as it will be needed probably next to get this bug fixed faster:
- first try mozilla-central builds:
https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/
- next, deeper in mozilla-inbound builds:
https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/

Before this, try also Firefox Aurora (version 37) and Firefox Nightly (version 38) to make sure it isn't fixed in these builds, and path wasn't uplifted to beta and stable for some reasons.

Comment 9

[Alice0775 White]

I can reproduce on ubuntu, but not on window.

Pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=8998763a34f5&tochange=475377e005de

Regressed by:
475377e005de	Dave Townsend — Bug 1103455: Change the events used to popup the search suggestions to avoid showing them when opening context menus. r=florian

Comment 10

[:Gijs (he/him)]

This seems serious. I can repro on OS X 36b. Florian, do you have cycles to look?

Comment 11

[Florian Quèze [:florian]]

Attachment: Fix

This is obviously caused by https://hg.mozilla.org/mozilla-central/rev/475377e005de#l5.12

The last paragraph of bug 1103455 comment 30 explains what that test is attempting to do. Currently that test condition is true all the time because event.target is the XUL textbox, and this.field is an HTMLInputElement. I think my patch makes this test do what it was actually intended to do. I verified that this causes the event handler to return early when right clicking the search icon, but not when right clicking the text field of the searchbox or location bar. It fixes the bug.

(In reply to :Gijs Kruitbosch from comment #10)
> Florian, do you have cycles to look?

I think the answer is no, but I was curious enough to look anyway, and the fix is trivial. However I don't think I can find time right now to write a test, and this probably deserves one.

Comment 12

[Florian Quèze [:florian]]

Forgot to paste the try link: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb0121a9a1b2

Comment 13

[Florian Quèze [:florian]]

[Tracking Requested - why for this release]: regression we shipped in Firefox 35 (bug 1103455). It affects Mac and Linux; not Windows.

Comment 14

[Dave Townsend [:mossop]]

Comment on attachment 8562835 [details] [diff] [review]
Fix

Review of attachment 8562835 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for catching this, I could have sworn I checked that when I added it.

Comment 15

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/c1963c7ffab2

Comment 16

[Florian Quèze [:florian]]

Comment on attachment 8562835 [details] [diff] [review]
Fix

Approval Request Comment
[Feature/regressing bug #]: bug 1103455
[User impact if declined]: Can't copy the url by using the context menu that appears when right-clicking an unfocused location bar on Mac/Linux.
[Describe test coverage new/current, TreeHerder]: Unfortunately, neither Dave nor I have time to write a test now. QA will verify (I don't expect these requests to be granted now; but I'm setting the flags immediately so that I don't forget).
[Risks and why]: Low risk, one line patch.
[String/UUID change made/needed]: none.

Comment 17

[Lawrence Mandel [:lmandel] (use needinfo)]

I'm tracking because this is user visible and the context menu is associated with primary UI. I don't think that this needs to block the 36 release but assuming that this makes it to m-c today and is verified tomorrow, it may be able to be included in Beta 9.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c1963c7ffab2

Comment 19

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8562835 [details] [diff] [review]
Fix

We are going to make a beta 10, so, we can take it with us.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/58fa5b70d329

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e7fc79199789

Comment 22

[Florian Quèze [:florian]]

I can't reproduce the "right click the 'Location Bar' (URL Bar), that will result in highlighting (selecting) the entire URL" part on Ubuntu, so I think it's fine for QA to only verify on Mac.

Comment 23

[:Gijs (he/him)]

(In reply to Florian Quèze [:florian] [:flo] from comment #22)
> I can't reproduce the "right click the 'Location Bar' (URL Bar), that will
> result in highlighting (selecting) the entire URL" part on Ubuntu, so I
> think it's fine for QA to only verify on Mac.

I expect this depends on the value of browser.urlbar.clickSelectsAll . Alice, can you clarify?

Comment 24

[Alice0775 White]

(In reply to :Gijs Kruitbosch from comment #23)
> (In reply to Florian Quèze [:florian] [:flo] from comment #22)
> > I can't reproduce the "right click the 'Location Bar' (URL Bar), that will
> > result in highlighting (selecting) the entire URL" part on Ubuntu, so I
> > think it's fine for QA to only verify on Mac.
> 
> I expect this depends on the value of browser.urlbar.clickSelectsAll .
> Alice, can you clarify?

You should try newly created profile. Do not change any preferences.

Comment 25

[Andrei Vaida [:avaida]]

(In reply to Alice0775 White from comment #24)
> (In reply to :Gijs Kruitbosch from comment #23)
> > (In reply to Florian Quèze [:florian] [:flo] from comment #22)
> > > I can't reproduce the "right click the 'Location Bar' (URL Bar), that will
> > > result in highlighting (selecting) the entire URL" part on Ubuntu, so I
> > > think it's fine for QA to only verify on Mac.
> > 
> > I expect this depends on the value of browser.urlbar.clickSelectsAll .
> > Alice, can you clarify?
> 
> You should try newly created profile. Do not change any preferences.

I was able to confirm the fix for this issue on Mac OS X 10.9.5, but I'm unable to reproduce it on my Ubuntu 14.04 (x64) machine with a clean profile, as the input from the Location Bar is not selected on right-click.

Comment 26

[Alice0775 White]

This is for Linux and Mac. not for Windows.  see comment#13
Mark OS: All and set  Keywords: pp

Comment 27

[Alice0775 White]

(In reply to Alice0775 White from comment #26)
> This is for Linux and Mac. not for Windows.  see comment#13
> Mark OS: All and set  Keywords: pp

ignore this

Comment 28

[Florian Quèze [:florian]]

(In reply to Andrei Vaida, QA [:avaida] from comment #25)

> I was able to confirm the fix for this issue on Mac OS X 10.9.5, but I'm
> unable to reproduce it on my Ubuntu 14.04 (x64) machine with a clean
> profile, as the input from the Location Bar is not selected on right-click.

Actually, Gijs is correct in comment 23, to reproduce on linux you need to set browser.urlbar.clickSelectsAll to true in about:config.

Comment 29

[Andrei Vaida [:avaida]]

(In reply to Florian Quèze [:florian] [:flo] from comment #28)
> (In reply to Andrei Vaida, QA [:avaida] from comment #25)
> 
> > I was able to confirm the fix for this issue on Mac OS X 10.9.5, but I'm
> > unable to reproduce it on my Ubuntu 14.04 (x64) machine with a clean
> > profile, as the input from the Location Bar is not selected on right-click.
> 
> Actually, Gijs is correct in comment 23, to reproduce on linux you need to
> set browser.urlbar.clickSelectsAll to true in about:config.

Thanks, Florian! This is now verified fixed on:
 * Nightly 38.0a1 (2015-02-19),
 * Aurora 37.0a2 (2015-02-19),
 * Beta 36.0b10 (20150217132925),
using Ubuntu 14.04 (x64) and Mac OS X 10.9.5.