Clarify the fact that ALSA is needed to build on Linux

RESOLVED FIXED in Firefox 38

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: padenot, Assigned: padenot)

Tracking

unspecified
mozilla38
Points:
---

Firefox Tracking Flags

(firefox38 fixed)

Details

Attachments

(1 attachment)

These days, we can't really build at all without at least ALSA on Linux, for Web
Audio API, WebRTC, and various other things that output audio. The current text
implies we can disable audio altogether, but is clearly outdated.
Posted patch patchSplinter Review
Attachment #8559114 - Flags: review?(mh+mozilla)
Comment on attachment 8559114 [details] [diff] [review]
patch

Review of attachment 8559114 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +5606,5 @@
>  
>  if test -n "$MOZ_ALSA"; then
>      PKG_CHECK_MODULES(MOZ_ALSA, alsa, ,
>           [echo "$MOZ_ALSA_PKG_ERRORS"
> +          AC_MSG_ERROR([Need alsa for audio output on Linux. (On Ubuntu, you might try installing the package libasound2-dev.)])])

While you're here... Does building with --disable-alsa work? If not, we might as well remove the flag.
Attachment #8559114 - Flags: review?(mh+mozilla) → review+
(In reply to Mike Hommey [:glandium] from comment #2)
> Comment on attachment 8559114 [details] [diff] [review]
> patch
> 
> Review of attachment 8559114 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: configure.in
> @@ +5606,5 @@
> >  
> >  if test -n "$MOZ_ALSA"; then
> >      PKG_CHECK_MODULES(MOZ_ALSA, alsa, ,
> >           [echo "$MOZ_ALSA_PKG_ERRORS"
> > +          AC_MSG_ERROR([Need alsa for audio output on Linux. (On Ubuntu, you might try installing the package libasound2-dev.)])])
> 
> While you're here... Does building with --disable-alsa work? If not, we
> might as well remove the flag.

Yes, and everything works if you have the PulseAudio libs available.

If you disable both PulseAudio and Alsa, then some things obviously don't work (HTMLMediaElement, Web Audio API, WebRTC), but it compiles and you can do everything else fine.
https://hg.mozilla.org/mozilla-central/rev/c99e7a982123
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.