1129498 - Update remove_all_bookmarks() to use Bookmarks.jsm

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

remove_all_bookmarks() in toolkit/components/places/tests/head_common.js has to be updated to use Bookmarks.jsm.

In most cases it's used just to cleanup roots, but that's done by eraseEverything.

In other cases though, like in test_leftpane_corruption_handling.js, it's really needed to remove also other roots (like the left pane folder), we can do that with the new API, by fetching children of the root that are not the main roots and removing them.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1129498-Replace-remove_all_bookmarks-with-.erase.patch

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 8594749 [details] [diff] [review]
0001-Bug-1129498-Replace-remove_all_bookmarks-with-.erase.patch

Review of attachment 8594749 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/places/tests/unit/test_leftpane_corruption_handling.js
@@ +9,5 @@
>   */
>  
>  function run_test() {
> +  run_next_test();
> +}

This is no more needed on trunk, you can completely remove run_test

::: toolkit/components/places/tests/unit/test_update_frecency_after_delete.js
@@ +139,5 @@
> +  yield PlacesTestUtils.promiseAsyncUpdates();
> +  do_print("Bookmarked => frecency of URI should be != 0");
> +  do_check_neq(frecencyForUrl(TEST_URI), 0);
> +
> +  PlacesUtils.bookmarks.removeFolderChildren(PlacesUtils.unfiledBookmarksFolderId);

let's create bm2 inside a folder, and remove that folder. the test outcome should be the same, basically only one bookmark out of 2 is removed.
So we don't need removeFolderChildren here

@@ +156,2 @@
>    run_next_test();
>  }

can remove

::: toolkit/components/places/tests/unit/test_utils_getURLsForContainerNode.js
@@ +184,1 @@
>  }

can remove

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d8f98759d531

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d8f98759d531