1129499 - Update clang version on B2G Desktop OS X builders

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Daniel Holbert [:dholbert]]

As noted in bug 1128576 comment 3, we need to update the clang version on our b2g osx builds -- it's stuck on an old version that has a bug with handling of the "override" C++ keyword.

Not sure what revision we should bump it to - hopefully glandium might know? IIUC, our other clang-based builders already use a more recent version, so we probably just want to match them.

Here's a Try run with a red build due to this issue:
 https://treeherder.mozilla.org/#/jobs?repo=try&revision=77cada79a209
(It only shows up on the debug build because the code where we're hitting the issue happens to be #ifdef DEBUG.)

Comment 1

[Daniel Holbert [:dholbert]]

(needinfo=glandium to add any other information / dependencies / CC's that might be needed here.)

Comment 2

[Mike Hommey [:glandium]]

Just synchronize with what we're using for desktop browser builds.

Comment 3

[Daniel Holbert [:dholbert]]

I'm not 100% sure, but I'm guessing that means we'd need to update this file...
http://mxr.mozilla.org/mozilla-central/source/b2g/config/tooltool-manifests/macosx64/releng.manifest
...to have the same "clang_version" as this file...
http://mxr.mozilla.org/mozilla-central/source/browser/config/tooltool-manifests/macosx64/releng.manifest

Comment 4

[Daniel Holbert [:dholbert]]

...and hg blame says Rail last upgraded clang_version on the other builders in bug 870173 -- he must've just missed the b2g-on-OSX manifest in that bug.

Rail, perhaps you can take this?

Comment 5

[Mike Hommey [:glandium]]

clang_version is essentially indicative only. what needs to be updates is the sha512 and the size for clang.tar.bz2.

Comment 6

[Rail Aliiev [:rail]]

I probably just updated the hashes... The procedure is documented at https://wiki.mozilla.org/ReleaseEngineering/How_To/Clang_update

It requires some changes in the m-c tree to reflect the used version and the final binaries (or someone from releng can reproduce them for you).

BTW, ehsan had some issues with clang in bug 1123386

Comment 7

[Daniel Holbert [:dholbert]]

Thanks!

(In reply to Rail Aliiev [:rail] from comment #6)
> BTW, ehsan had some issues with clang in bug 1123386

I've only skimmed that bug, but I suspect that's orthogonal to the update we're talking about here.  Here, I'm just wanting us to use the same (already-built, or at least already-being-built) clang version to compile b2g-on-OSX as we use to compile firefox-on-OSX.

Whereas bug 1123386 is about tweaking how we build clang itself, IIUC.

Comment 8

[Daniel Holbert [:dholbert]]

(In reply to Rail Aliiev [:rail] from comment #6)
> I probably just updated the hashes...

I'm not clear on whether this (on its own) was supposed to fix this or not (it sounded like maybe it was, based on comment 5).  But FWIW, I just checked & verified that we're still using the same old clang version, based on a mozilla-inbound B2G Desktop OS X build log from today.

Rail, do you know what the next steps are here?

Comment 9

[Rail Aliiev [:rail]]

(In reply to Daniel Holbert [:dholbert] from comment #8)
> Rail, do you know what the next steps are here?

1) Figure out what version of clang we want to update to.

2) http://hg.mozilla.org/mozilla-central/file/default/build/unix/build-clang is what people use to simplify building and generating tooltool manifests

3) https://wiki.mozilla.org/ReleaseEngineering/Applications/Tooltool#How_to_upload_to_tooltool describes how to upload the files to tooltool without depending on a releng person. This should help testing new versions and iterating faster.

4) Once the built archive is uploaded to tooltool, you can update http://hg.mozilla.org/mozilla-central/file/default/browser/config/tooltool-manifests/macosx64/releng.manifest by the manifest generated in 2) and push to try to test

Feel free to poke me on IRC or here if something is not clear.

Comment 10

[Mike Hommey [:glandium]]

Again, the point of this bug is *not* to upgrade clang for Firefox builds. The point is to make the b2g desktop builds use the same clang as the Firefox builds. That is, synchronize b2g/config/tooltool-manifests/macosx64/releng.manifest and browser/config/tooltool-manifests/macosx64/releng.manifest

Comment 11

[Rail Aliiev [:rail]]

(In reply to Mike Hommey [:glandium] from comment #10)
> Again, the point of this bug is *not* to upgrade clang for Firefox builds.
> The point is to make the b2g desktop builds use the same clang as the
> Firefox builds. That is, synchronize
> b2g/config/tooltool-manifests/macosx64/releng.manifest and
> browser/config/tooltool-manifests/macosx64/releng.manifest

Oh! Sorry, I misunderstood the point.

Just copy the manifest over and run it through try then?

Comment 12

[Daniel Holbert [:dholbert]]

Attachment: update releng.manifest for b2g clang build on OSX

OK, I think this should do it then.

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f819db4985b

Comment 13

[Daniel Holbert [:dholbert]]

Comment on attachment 8561129 [details] [diff] [review]
update releng.manifest for b2g clang build on OSX

Looks good on Try. The build log contains:
{
"clang_version": "r183744"
}
http://ftp.mozilla.org/pub/mozilla.org/b2g/try-builds/[e-mail]-1f819db4985b/try-macosx64_gecko-debug/try-macosx64_gecko-debug-bm87-try1-build3265.txt.gz

...which seems to indicate that this did work.  (A build log from a separate Try run without the patch has "clang_version": "r170890" instead.)

Also, a separate Try run with this patch *and* bug 1128576's patch is green:
 https://treeherder.mozilla.org/#/jobs?repo=try&revision=a10fdab84e14
...which shows that this update does indeed prevent the bustage that prompted me to file this bug in the first place. Hooray!

Comment 14

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e1cad69078a1

Comment 15

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/mozilla-central/rev/e1cad69078a1