Honor DNT for Loop analytics

RESOLVED FIXED in Firefox 38

Status

Hello (Loop)
Client
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: abr, Assigned: abr)

Tracking

unspecified
mozilla38
Points:
1
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox38 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8559234 [details] [diff] [review]
Honor DNT for Loop analytics

Untested, but this should be all it takes.
(Assignee)

Comment 2

3 years ago
Created attachment 8559237 [details] [diff] [review]
Honor DNT for Loop analytics
(Assignee)

Updated

3 years ago
Attachment #8559234 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Assignee: adam → nobody
(Assignee)

Comment 3

3 years ago
Comment on attachment 8559237 [details] [diff] [review]
Honor DNT for Loop analytics

Mark: I'm not going to have the cycles to test that this works, and we really want to get it into the 0.13.4 release, but it's a really simple change. Can I have you run this through its paces (basically, run with DNT turned on and make sure nothing touches the google servers), and put an r+ on it?

If there's an issue with the code as-is, I'd like to hand ownership off to you or someone else on the team for fixing and landing.

Thanks!
Attachment #8559237 - Flags: review?(standard8)
(Assignee)

Comment 4

3 years ago
After some further digging, it appears that this is well-worn ground, and that the use of Google Analytics isn't "tracking" in the sense that DNT encompasses. Rather than attempting to summarize the nuance here, I'll point to this email thread on governance:

https://groups.google.com/forum/?hl=en&fromgroups=#!search/mozilla$20governance$20google$20analytics/mozilla.governance/9IQvIubDOXU/0tWVVlrUJOQJ

Also of relevance are Bug 697436 comment 14 and Bug 858839 comment 18.

As our usage appears to be within the bounds of existing Mozilla policy and practices, the changes proposed by this bug are unnecessary. I'm closing as WONTFIX.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
(Assignee)

Comment 5

3 years ago
Based on input from our privacy folks, we're going to want to land this in the client as time allows. The current release would be ideal, but deferring to the next would be acceptable.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Created attachment 8561327 [details] [diff] [review]
Honor DNT for Loop analytics.

I've now tested this across FF, Opera, Chrome & Safari - unfortunately there's a few different
ways that DNT is implemented, hence we need more than just one check. This catches all the major browsers and hopefully should catch any others we need.
Attachment #8561327 - Flags: review?(nperriault)
Comment on attachment 8561327 [details] [diff] [review]
Honor DNT for Loop analytics.

I don't mind who reviews this, whoever is first is fine.
Attachment #8561327 - Flags: review?(mdeboer)
Attachment #8559237 - Attachment is obsolete: true
Attachment #8559237 - Flags: review?(standard8)
Assignee: nobody → adam
Iteration: --- → 38.2 - 9 Feb
Points: --- → 1
Comment on attachment 8561327 [details] [diff] [review]
Honor DNT for Loop analytics.

Review of attachment 8561327 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8561327 - Flags: review?(nperriault)
Attachment #8561327 - Flags: review?(mdeboer)
Attachment #8561327 - Flags: review+
https://hg.mozilla.org/integration/fx-team/rev/e9a2ce8b8586
Target Milestone: --- → mozilla38
https://hg.mozilla.org/mozilla-central/rev/e9a2ce8b8586
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED

Comment 11

3 years ago
In my opinion, the conditional statement for excluding GA when DNT signal is turned on should be ignored for browsers that are shipped from the factory with DNT on as it does not signal user intent. Namely IE10 should be ignored: http://en.wikipedia.org/wiki/Do_Not_Track#Internet_Explorer_10_default_setting_controversy
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.