Closed Bug 112953 Opened 24 years ago Closed 24 years ago

win32 optimized trace-malloc build

Categories

(SeaMonkey :: General, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: blythe, Assigned: netscape)

Details

(Keywords: memory-footprint)

Attachments

(1 file)

Get win32 trace-malloc mozilla to build, which should be the configuration you desire to run trace-malloc under. Currently, it is known only to work under win32 debug builds.
Keywords: footprint
Need to request review and all that jazz.
Comment on attachment 60251 [details] [diff] [review] Patch to build trace-malloc in a non-debug configuration. r=dp
Attachment #60251 - Flags: review+
brendan, can you sr= :-)
dveditz, brendan can either one of you sr?
Comment on attachment 60251 [details] [diff] [review] Patch to build trace-malloc in a non-debug configuration. Wow, ugly THERECANBENODEBUG hacks, but necessary I'm sure. You'll want to get the nsprpub/gmakefile.win patch approved by wtc and landed in the NSPR trunk as well as in the client branch, I think. Random style vandalism whinage: - do { + while(0 < framenum) { (space between while and (, use framenum > 0 if you can although I don't insist on the latter :-). Similar comments for later if(0 != getsymRes) and brace style, but I'm whining too much now. When in Rome! /be
Attachment #60251 - Flags: superreview+
Wan-Teh, desire review of gmakefile.win in patch provided. Brendan mentions an NSPR trunk and client branch, of which I have no knowledge. Cathleen, can you inform me of what these are?
Status: NEW → ASSIGNED
wtc, can you help review changes in gmakefile.win? thx!!!
Comment on attachment 60251 [details] [diff] [review] Patch to build trace-malloc in a non-debug configuration. The change to nsprpub/gmakefile.win is fine.
all changes except for nsprpub change to gmakefile.win are checked in (after style mods per brendan ;). Handing bug over the Chris so that he can close it when the nspr gmakefile.win change lands.
Assignee: blythe → seawood
Status: ASSIGNED → NEW
Checking in mozilla/nsprpub/gmakefile.win; /cvsroot/mozilla/nsprpub/gmakefile.win,v <-- gmakefile.win new revision: 1.4; previous revision: 1.3 done Checking in nsprpub/gmakefile.win; /cvsroot/mozilla/nsprpub/gmakefile.win,v <-- gmakefile.win new revision: 1.3.2.1; previous revision: 1.3 done
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: