Closed Bug 1129597 Opened 5 years ago Closed 5 years ago

Unable to edit keyword

Categories

(Firefox :: Preferences, defect, P2)

36 Branch
defect
Points:
3

Tracking

()

VERIFIED FIXED
Firefox 39
Iteration:
38.3 - 23 Feb
Tracking Status
firefox35 --- unaffected
firefox36 --- unaffected
firefox37 --- affected
firefox38 --- verified
firefox39 --- verified
firefox-esr31 --- unaffected
firefox-esr38 --- affected

People

(Reporter: alice0775, Assigned: Gijs)

References

Details

Attachments

(2 files)

Attached image screenshot
Steps To Reproduce:
1. Open about:preferences#search
2. Double click to display keyword input field in the Search engine list view
   (e.g. Double click "Bing" row)
3. Type keyword and do not press ENTER key now
   (e.g. "b" not include quotation)
3. Click "General" pane
4. Click "Search" pane
5. Scroll the Search engine list view
6. Attempt to continue to type keyword
   (e.g. "ing" following "b")

Actual Results:
Unable to edit keyword.

Expected Results:
Should be able to continue edit the keyword
Blocks: 1106559
No longer blocks: fx34-searchui
(In reply to Alice0775 White from comment #0)

> Actual Results:
> Unable to edit keyword.
> 
> Expected Results:
> Should be able to continue edit the keyword

I think the expected result is rather that leaving the search pref pane should remove the textfield, as it appears the tree is no longer in editing mode when returning.
This is not a bug specific to in-content preferences, so removing it from the ship-incontent-prefs meta bug.
No longer blocks: ship-incontent-prefs
Sorry, I now see that this is specific to in-content prefs. Adding back the blocker.
OS: Windows 7 → All
Priority: -- → P2
Hardware: x86_64 → All
Points: --- → 3
The easiest way to fix this (and bug 1129587) is to hide the input once the user has changed panes.
Can you pick this up, Gijs? (Asking specifically because this and the dep will give you more bugs towards your Q1 deliverable.)
Flags: needinfo?(gijskruitbosch+bugs)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 39.1 - 9 Mar
Flags: needinfo?(gijskruitbosch+bugs)
Attachment #8567873 - Flags: review?(florian)
Comment on attachment 8567873 [details] [diff] [review]
hide search engine keyword editor on blur,

Works well and also fixes bug 1129587.

I wonder if we should look for a more generic solution, but if this is the only editable tree we'll ever have in the in-content prefs, I guess that would be more work than this edge case is worth.
Attachment #8567873 - Flags: review?(florian) → review+
remote:   https://hg.mozilla.org/integration/fx-team/rev/7aed927f0935
Flags: qe-verify+
Flags: in-testsuite-
Flags: firefox-backlog+
Whiteboard: [fixed-in-fx-team]
Duplicate of this bug: 1129587
Iteration: 39.1 - 9 Mar → 38.3 - 23 Feb
https://hg.mozilla.org/mozilla-central/rev/7aed927f0935
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
QA Contact: petruta.rasa
Verified as fixed using Nightly 39.0a1 under Win 7 64-bit, Mac OSX 10.10 and Ubuntu 12.04 32-bit.

I believe it should be uplifted to 38 where inline preferences will be default.
Status: RESOLVED → VERIFIED
Comment on attachment 8567873 [details] [diff] [review]
hide search engine keyword editor on blur,

Approval Request Comment
[Feature/regressing bug #]: search engine prefs
[User impact if declined]: in some cases, focus state and/or the search tree gets confused if you switch panes in in-content prefs
[Describe test coverage new/current, TreeHerder]: no
[Risks and why]: pretty low, just making sure we stop editing when the pane disappears
[String/UUID change made/needed]: nope
Attachment #8567873 - Flags: approval-mozilla-aurora?
Attachment #8567873 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified as fixed using Nightly Firefox 38 beta 1 under Win 7 64-bit, Mac OSX 10.10 and Ubuntu 12.04 32-bit.
Flags: qe-verify+ → in-qa-testsuite+
Blocks: 1532633
See Also: → 1532633
You need to log in before you can comment on or make changes to this bug.