1129597 - Unable to edit keyword

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P2)

Description

[Alice0775 White]

Attachment: screenshot

Steps To Reproduce:
1. Open about:preferences#search
2. Double click to display keyword input field in the Search engine list view
   (e.g. Double click "Bing" row)
3. Type keyword and do not press ENTER key now
   (e.g. "b" not include quotation)
3. Click "General" pane
4. Click "Search" pane
5. Scroll the Search engine list view
6. Attempt to continue to type keyword
   (e.g. "ing" following "b")

Actual Results:
Unable to edit keyword.

Expected Results:
Should be able to continue edit the keyword

Comment 1

[Florian Quèze [:florian]]

(In reply to Alice0775 White from comment #0)

> Actual Results:
> Unable to edit keyword.
> 
> Expected Results:
> Should be able to continue edit the keyword

I think the expected result is rather that leaving the search pref pane should remove the textfield, as it appears the tree is no longer in editing mode when returning.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

This is not a bug specific to in-content preferences, so removing it from the ship-incontent-prefs meta bug.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Sorry, I now see that this is specific to in-content prefs. Adding back the blocker.

Comment 4

[Tim Nguyen :ntim]

The easiest way to fix this (and bug 1129587) is to hide the input once the user has changed panes.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Can you pick this up, Gijs? (Asking specifically because this and the dep will give you more bugs towards your Q1 deliverable.)

Comment 6

[:Gijs (out for now; he/him)]

Attachment: hide search engine keyword editor on blur,

Comment 7

[Florian Quèze [:florian]]

Comment on attachment 8567873 [details] [diff] [review]
hide search engine keyword editor on blur,

Works well and also fixes bug 1129587.

I wonder if we should look for a more generic solution, but if this is the only editable tree we'll ever have in the in-content prefs, I guess that would be more work than this edge case is worth.

Comment 8

[:Gijs (out for now; he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/7aed927f0935

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7aed927f0935

Comment 11

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified as fixed using Nightly 39.0a1 under Win 7 64-bit, Mac OSX 10.10 and Ubuntu 12.04 32-bit.

I believe it should be uplifted to 38 where inline preferences will be default.

Comment 12

[:Gijs (out for now; he/him)]

Comment on attachment 8567873 [details] [diff] [review]
hide search engine keyword editor on blur,

Approval Request Comment
[Feature/regressing bug #]: search engine prefs
[User impact if declined]: in some cases, focus state and/or the search tree gets confused if you switch panes in in-content prefs
[Describe test coverage new/current, TreeHerder]: no
[Risks and why]: pretty low, just making sure we stop editing when the pane disappears
[String/UUID change made/needed]: nope

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/05820d683ab7

Comment 14

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified as fixed using Nightly Firefox 38 beta 1 under Win 7 64-bit, Mac OSX 10.10 and Ubuntu 12.04 32-bit.