1129607 - Regression: Time it takes to show engines/results on first launch initial search has regressed

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

[Tracking Requested - why for this release]:

Currently on trunk, it takes longer to retrieve engine list and results on first time search.

Comment 1

[Aaron Train [:aaronmt]]

Attachment: video.mp4

Comment 2

[Aaron Train [:aaronmt]]

> 03:41  mfinkle:	it's the async init
> 03:41  mfinkle:	if i do: first run, awesome screen, then settings
> 03:41  mfinkle:	the list is shown normally

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: early-init-search v0.1

This patch will delay init the Search service along with some other performance impacting services. Because we are now delay-initing the service instead of lazy-initing the service, the country code fetch happens before we attempt to display the list of search engines (or use them in the awesomescreen). 

We still need to wait for Gecko to load before the engines are available though, but the regression should be fixed.

Comment 4

[:Margaret Leibovic]

Comment on attachment 8560014 [details] [diff] [review]
early-init-search v0.1

Review of attachment 8560014 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me. Let's just monitor startup performance to make sure this isn't regressing that by accident.

::: mobile/android/chrome/content/browser.js
@@ +373,4 @@
>            Cc["@mozilla.org/login-manager;1"].getService(Ci.nsILoginManager);
> +          Services.search.init();
> +
> +          // Spin up some features which impact performance.

We don't need this comment twice.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/fx-team/rev/e743d6237be9

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8560014 [details] [diff] [review]
early-init-search v0.1

Approval Request Comment
[Feature/regressing bug #]: bug 1117186 exposes this regression because we now fetch the country code
[User impact if declined]: Noticeable delay when displaying the Awesomescreen search or the Setting search liist
[Describe test coverage new/current, TreeHerder]: Minimal so far
[Risks and why]: Low risk since we aren't doing anything new, just doing it a bit sooner. Might cause a startup regression that would be caught by Autophone tests.
[String/UUID change made/needed]: None

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e743d6237be9

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing for uplift.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/df8447ffc4ca

https://hg.mozilla.org/releases/mozilla-beta/rev/c1578e681849