1129621 - Distinguish between installable apps and non-installable content in Rocketbar search endpoint

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Search, defect, P4)

Description

[Peter Dolanjski [:pdol]]

Right now all apps found via the search API used by Rocketbar:
https://marketplace.firefox.com/api/v2/apps/search/rocketbar/?q={q}&limit={limit}
are prefixed with the word "Install" since all apps from Marketplace require installation.

In the event that Marketplace adds other forms of non-installable content (like websites) in the future, it would be ideal if they could be surfaced through the same Rocketbar experience, albeit without the "Install" prefix.  As such, Rocketbar needs a way to distinguish between those content types to make a decision about whether or not to prefix "Install".

Comment 1

[Ben Francis [:benfrancis]]

What types of content are likely to be supported?

I would suggest that non-app results could use "url" instead of "manifest_url" given that they won't have a manifest URL, we could then distinguish between them that way.

We might want to reserve the "type" property to reflect the value of the "type" property in Open Web App Manifests in future? Though we could probably parse that from the manifest if we needed to...

Comment 2

[Wil Clouser [:clouserw]]

"url" sounds reasonable.  If you want to use "urL" then this bug doesn't need to block anything since we aren't going to have anything except apps for a while.

When we do this, I think it's just a matter of modifying https://github.com/mozilla/zamboni/blob/master/mkt/webapps/serializers.py#L589 and related tests.

Comment 3

[David Bialer [:dbialer]]

url sounds like a good idea.  Can we make sure theat FxOS 2.2+ understands this?

Comment 4

[David Bialer [:dbialer]]

do we need a rocketbar bug to support this?

Comment 5

[Wil Clouser [:clouserw]]

That's what bug 1129625 is.  Peter says it doesn't need to be marked 2.2+

Comment 6

[Wil Clouser [:clouserw]]

Setting as a P4 as it doesn't sound like this made it into 2.2