1129650 - Touching navigator.mozId causes an error NS_ERROR_FACTORY_NOT_REGISTERED

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Stuart Colville [:muffinresearch]]

In payments we look to see if navigator.mozId is defined to know if nativeFxA is available.

In FF Android nightly 38.0a1 (2015-02-04) this causes a JS error:

W/GeckoConsole( 8958): [JavaScript Error: "NS_ERROR_FACTORY_NOT_REGISTERED: " {file: "http://jsbin.com/juxasu" line: 19}]

Here's a test-case:

http://jsbin.com/juxasu

Comment 1

[Andy McKay]

Any ideas Sam?

Comment 2

[Sam Penrose]

This means that the WebIDL machinery doesn't like its mozId implementation on Android. You can find a WebIDL savant to determine what's going on, or simply skip the check on Android (since mozId won't work on that platform).

Comment 3

[Andy McKay]

Thanks, ferjm is our WebIDL savant.

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

We don't support mozId on Android, so we shouldn't be exposing it.

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Not sure if this is the right approach, but let's give it a try.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fca61b9ed2ae

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v2

Ok, that didn't work.

It seems that we exposed navigator.id for Desktop on bug 753239. Not sure why, but I believe we don't need to do that. Matt, Sam, do you know if there is any reason for exposing navigator.id in Desktop?

Second try removing mozId stuff from Desktop https://tbpl.mozilla.org/?tree=Try&rev=2237ed00d4d7

Comment 7

[Sam Penrose]

navigator.id was initially written for Persona, and its possible we wanted the option of a native implementation for desktop. That option is no longer viable, and we should certainly hide it, if not remove it.

Comment 8

[Matthew N. [:MattN]]

Comment on attachment 8561954 [details] [diff] [review]
v2

Review of attachment 8561954 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, this was for native BrowserID but it's already broken and we should remove it so it's fine to not build it.

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v3

Thanks Matthew!

Andrea, this patch avoids exposing navigator.mozId on desktop and android, but it still exposes it on b2g.

Comment 10

[Fernando Jiménez Moreno [:ferjm]]

Thank you Andrea.

https://hg.mozilla.org/integration/mozilla-inbound/rev/80987d26adfb

Comment 11

[(Out Sep 17-23) Ryan VanderMeulen]

Backed out for hitting intermittent OSX packaging failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/e2ca47393208

https://treeherder.mozilla.org/logviewer.html#?job_id=6971535&repo=mozilla-inbound

07:13:57 INFO - Error: /builds/slave/m-in-osx64-0000000000000000000/build/src/obj-firefox/i386/browser/installer/package-manifest:455: File missing in ../../dist: Nightly.app/Contents/Resources/modules/DOMIdentity.jsm

Comment 12

[Fernando Jiménez Moreno [:ferjm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8c8b685a7204

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8c8b685a7204