Closed Bug 1129650 Opened 5 years ago Closed 5 years ago
.moz Id causes an error NS _ERROR _FACTORY _NOT _REGISTERED
Any ideas Sam?
This means that the WebIDL machinery doesn't like its mozId implementation on Android. You can find a WebIDL savant to determine what's going on, or simply skip the check on Android (since mozId won't work on that platform).
Thanks, ferjm is our WebIDL savant.
We don't support mozId on Android, so we shouldn't be exposing it.
Not sure if this is the right approach, but let's give it a try. https://treeherder.mozilla.org/#/jobs?repo=try&revision=fca61b9ed2ae
Ok, that didn't work. It seems that we exposed navigator.id for Desktop on bug 753239. Not sure why, but I believe we don't need to do that. Matt, Sam, do you know if there is any reason for exposing navigator.id in Desktop? Second try removing mozId stuff from Desktop https://tbpl.mozilla.org/?tree=Try&rev=2237ed00d4d7
Attachment #8561492 - Attachment is obsolete: true
navigator.id was initially written for Persona, and its possible we wanted the option of a native implementation for desktop. That option is no longer viable, and we should certainly hide it, if not remove it.
Comment on attachment 8561954 [details] [diff] [review] v2 Review of attachment 8561954 [details] [diff] [review]: ----------------------------------------------------------------- Yeah, this was for native BrowserID but it's already broken and we should remove it so it's fine to not build it.
Thanks Matthew! Andrea, this patch avoids exposing navigator.mozId on desktop and android, but it still exposes it on b2g.
Attachment #8568514 - Flags: review?(amarchesini)
Attachment #8568514 - Flags: review?(amarchesini) → review+
Attachment #8561954 - Attachment is obsolete: true
Thank you Andrea. https://hg.mozilla.org/integration/mozilla-inbound/rev/80987d26adfb
Backed out for hitting intermittent OSX packaging failures. https://hg.mozilla.org/integration/mozilla-inbound/rev/e2ca47393208 https://treeherder.mozilla.org/logviewer.html#?job_id=6971535&repo=mozilla-inbound 07:13:57 INFO - Error: /builds/slave/m-in-osx64-0000000000000000000/build/src/obj-firefox/i386/browser/installer/package-manifest:455: File missing in ../../dist: Nightly.app/Contents/Resources/modules/DOMIdentity.jsm
Depends on: 1141848
You need to log in before you can comment on or make changes to this bug.