Convert Mozmill test 'functional/testTabbedBrowsing/testNewWindow.js' to Marionette

RESOLVED FIXED in mozilla38

Status

P2
normal
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: whimboo, Assigned: rbillings)

Tracking

(Blocks: 1 bug)

unspecified
mozilla38
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
This bug will cover the necessary work to do to convert the following test into Marionette.

http://hg.mozilla.org/qa/mozmill-tests/file/default/firefox/tests/functional/testTabbedBrowsing/testNewWindow.js
(Reporter)

Comment 1

4 years ago
Here is my feedback after looking at this test:

* The test only covers opening a new window by menu. Our unit tests already make use of shortcuts. So we outreach this test already.

* I don't see a reason why to check for the default home page in that test. It is not related to opening and closing a window.

* Further I don't see why this test is part of the tabbed browsing folder when it is covering windows. This may be a relict from Litmus.


So I would suggest we do not spend time on this test to get it converted, given that we perfectly cover this already in our unit tests:

https://github.com/mozilla/firefox-ui-tests/blob/master/firefox_puppeteer/tests/test_windows.py#L79
https://github.com/mozilla/firefox-ui-tests/blob/master/firefox_puppeteer/tests/test_windows.py#L172

The only thing I see here is that we may have to make it explicit to use the menu and not the default triggering method in line 174 and 177 of the above unit test. Rebecca would you mind to cover that?
(Assignee)

Comment 3

4 years ago
Created attachment 8560073 [details] [review]
Link to GitHub pull request: https://github.com/mozilla/firefox-ui-tests/pull/72

Updated two instances of open browser to use menu option, per Comment 1
(Reporter)

Updated

4 years ago
Attachment #8560073 - Flags: review?(hskupin)
(Reporter)

Updated

4 years ago
Assignee: nobody → rbillings
Status: NEW → ASSIGNED
(Reporter)

Updated

4 years ago
Attachment #8560073 - Flags: review?(hskupin) → review+
(Reporter)

Comment 4

4 years ago
https://github.com/mozilla/firefox-ui-tests/commit/f30fd0fea8f79ff2cdb8bbece2d6c66937e30cf9
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
(Reporter)

Updated

4 years ago
Priority: P1 → P2
Product: Mozilla QA → Testing
You need to log in before you can comment on or make changes to this bug.