1129652 - Convert Mozmill test 'functional/testTabbedBrowsing/testNewWindow.js' to Marionette

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This bug will cover the necessary work to do to convert the following test into Marionette.

http://hg.mozilla.org/qa/mozmill-tests/file/default/firefox/tests/functional/testTabbedBrowsing/testNewWindow.js

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Here is my feedback after looking at this test:

* The test only covers opening a new window by menu. Our unit tests already make use of shortcuts. So we outreach this test already.

* I don't see a reason why to check for the default home page in that test. It is not related to opening and closing a window.

* Further I don't see why this test is part of the tabbed browsing folder when it is covering windows. This may be a relict from Litmus.


So I would suggest we do not spend time on this test to get it converted, given that we perfectly cover this already in our unit tests:

https://github.com/mozilla/firefox-ui-tests/blob/master/firefox_puppeteer/tests/test_windows.py#L79
https://github.com/mozilla/firefox-ui-tests/blob/master/firefox_puppeteer/tests/test_windows.py#L172

The only thing I see here is that we may have to make it explicit to use the menu and not the default triggering method in line 174 and 177 of the above unit test. Rebecca would you mind to cover that?

Comment 2

[Rebecca Billings [:rbillings]]

I've added the code here: https://github.com/rbillings/firefox-ui-tests/tree/newwindow

Comment 3

[Rebecca Billings [:rbillings]]

Attachment: Link to GitHub pull request: https://github.com/mozilla/firefox-ui-tests/pull/72

Updated two instances of open browser to use menu option, per Comment 1

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

https://github.com/mozilla/firefox-ui-tests/commit/f30fd0fea8f79ff2cdb8bbece2d6c66937e30cf9