1129727 - Hiding "Make Template" button leaves "useful for filing several similar bugs"

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[keni]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_5) AppleWebKit/600.2.5 (KHTML, like Gecko) Version/7.1.2 Safari/537.85.11

Steps to reproduce:

Installed latest code from git (64250f2a4ef73d8b2686d275dc39aee4d389b0e6).
Start editing a new bug (login, hit New).  (You will be in the test component.)
If "Hide Advanced Fields" is showing, toggle it off ("Show Advanced Fields")
Scroll down to "Submit Bug" button.


Actual results:

Says "(useful for filing several similar bugs)"


Expected results:

Since the "Make Template" button is hidden, so should the help text.

Comment 1

[keni]

Possible fix:
diff --git a/template/en/default/bug/create/create.html.tmpl b/template/en/default/bug/crindex d8abec6..da750af 100644
--- a/template/en/default/bug/create/create.html.tmpl
+++ b/template/en/default/bug/create/create.html.tmpl
@@ -617,7 +617,9 @@ TUI_hide_default('attachment_text_field');
       <input type="submit" name="maketemplate" id="maketemplate"
              value="Make Template"
              onclick="bz_no_validate_enter_bug=true" class="expert_fields">
-      (useful for filing several similar bugs)
+       <span class="expert_fields">
+         (useful for filing several similar bugs)
+       </span>
     </td>
   </tr>
 </tbody>

Comment 2

[Frédéric Buclin]

Confirmed. This is a regression due to bug 488942.

Comment 3

[Matt Selsky [:selsky]]

Attachment: v1

Comment 4

[Gervase Markham [:gerv]]

Comment on attachment 8561950 [details] [diff] [review]
v1

r=gerv.

Gerv

Comment 5

[Gervase Markham [:gerv]]

To ssh://[e-mail]/bugzilla/bugzilla.git
   73aea8f..cd284d4  master -> master

Gerv