Closed
Bug 1129755
Opened 10 years ago
Closed 10 years ago
AutoCompletePopup should detach its docshell on unload
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 38
| Tracking | Status | |
|---|---|---|
| firefox38 | --- | fixed |
People
(Reporter: mccr8, Assigned: billm)
References
Details
(Whiteboard: [MemShrink])
Attachments
(1 file)
|
1.67 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
Bill and I noticed that AutoCompletePopup seems to leak its docshell, probably until we shut down the form fill controller (which is why it shows up with the ++DOCSHELL leak detector, but not the XPCOM leak detector). That's kind of bad, though not as bad as a window leak.
|
Reporter | |
Comment 1•10 years ago
|
||
Bill actually wrote the patch, but it is pretty trivial so I can deal with getting it landed and reviewed.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e742f39b6c33
|
|
Reporter | |
Comment 2•10 years ago
|
||
try run looks fine.
|
|
Reporter | |
Updated•10 years ago
|
Attachment #8559603 -
Flags: review?(felipc)
|
|
Reporter | |
Updated•10 years ago
|
Assignee: continuation → wmccloskey
|
||
Updated•10 years ago
|
Attachment #8559603 -
Flags: review?(felipc) → review+
|
|
Reporter | |
Updated•10 years ago
|
Keywords: checkin-needed
|
|
Reporter | |
Comment 3•10 years ago
|
||
Keywords: checkin-needed
|
||
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
You need to log in
before you can comment on or make changes to this bug.
Description
•