1129756 - Revert test changes in bug 1041631

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Masatoshi Kimura [:emk]]

Now "Symbol" is always defined again.

Incidentally, the test should have been modified to |{name:"Symbol", nightly: true},| instead of adding a custom logic. The logic is a bit tautologic. (If "Symbol" is defined, test if "Symbol" is defined.)

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4169ead5bf05

Comment 2

[Masatoshi Kimura [:emk]]

Ping?

Comment 3

[Jason Orendorff [:jorendorff]]

Comment on attachment 8560072 [details] [diff] [review]
patch

Review of attachment 8560072 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: js/src/tests/ecma_6/Symbol/enumeration-order.js
@@ +1,5 @@
>  /* Any copyright is dedicated to the Public Domain.
>   * http://creativecommons.org/licenses/publicdomain/ */
>  
> +// ES6 draft rev 25 (2014 May 22), 9.1.12 "[[OwnPropertyKeys]] ()":
> +// 

Not your bug, but I meant to write a brief explanation here. Could you please complete the comment on this line as follows?

    // Symbols follow all other property keys in the result list.

Comment 4

[Masatoshi Kimura [:emk]]

Thanks, landed with the suggested change:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3292bc65a0ae

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3292bc65a0ae