Closed Bug 1129756 Opened 5 years ago Closed 5 years ago

Revert test changes in bug 1041631

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: emk, Assigned: emk)

References

Details

Attachments

(1 file)

Now "Symbol" is always defined again.

Incidentally, the test should have been modified to |{name:"Symbol", nightly: true},| instead of adding a custom logic. The logic is a bit tautologic. (If "Symbol" is defined, test if "Symbol" is defined.)
Summary: Revert test_interfaces.html and test_worker_interfaces.html to test "Symbol" unconditionally → Revert test changes in bug 1041631
Ping?
Comment on attachment 8560072 [details] [diff] [review]
patch

Review of attachment 8560072 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: js/src/tests/ecma_6/Symbol/enumeration-order.js
@@ +1,5 @@
>  /* Any copyright is dedicated to the Public Domain.
>   * http://creativecommons.org/licenses/publicdomain/ */
>  
> +// ES6 draft rev 25 (2014 May 22), 9.1.12 "[[OwnPropertyKeys]] ()":
> +// 

Not your bug, but I meant to write a brief explanation here. Could you please complete the comment on this line as follows?

    // Symbols follow all other property keys in the result list.
Attachment #8560072 - Flags: review?(jorendorff) → review+
Thanks, landed with the suggested change:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3292bc65a0ae
https://hg.mozilla.org/mozilla-central/rev/3292bc65a0ae
Assignee: nobody → VYV03354
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.