1129763 - Add pref to modify the timing to display the visual warning for long transaction

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Peter Chang[:pchang]]

The timing to display the visual warning for long transaction is 200 ms and the long transaction usually happens because of the time cost for content rendering. Adding the preference to customize the timing can help us to detect some apps that spend time more than 16 ms but less than 200 ms.

Comment 1

[Peter Chang[:pchang]]

BTW, I think it is also useflu to dump the child process id when the long transaction happens, especially the app switches in b2g.

Comment 2

[Peter Chang[:pchang]]

Attachment: Add pref for the threshold of frame visual warning

Comment 3

[Benoit Girard (:BenWa)]

Comment on attachment 8559626 [details] [diff] [review]
Add pref for the threshold of frame visual warning

Review of attachment 8559626 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/LayerTransactionParent.cpp
@@ +625,5 @@
> +        severity = 1.f;
> +      }
> +      mLayerManager->VisualFrameWarning(severity);
> +#ifdef PR_LOGGING
> +      PR_LogPrint("LayerTransactionParent::RecvUpdate transaction from process %d took %f ms %p",

Looks like you have an extra %p.

::: gfx/thebes/gfxPrefs.h
@@ +277,5 @@
>    DECL_GFX_PREF(Live, "layers.dump-decision",                  LayersDumpDecision, bool, false);
>    DECL_GFX_PREF(Live, "layers.dump-client-layers",             DumpClientLayers, bool, false);
>    DECL_GFX_PREF(Live, "layers.dump-host-layers",               DumpHostLayers, bool, false);
>  #endif
> +  DECL_GFX_PREF(Live, "layers.transaction.warning_ms",         LayerTransactionWarning, uint32_t, 200);

warning-ms to be consistent with the layers.* preferences

Comment 4

[Peter Chang[:pchang]]

Attachment: Add pref for the threshold of frame visual warning v2

Update patch to address reviewer's comment.

Comment 5

[Peter Chang[:pchang]]

Try is good.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b82ca5319b5

Comment 6

[Peter Chang[:pchang]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/319575fa5f31

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/319575fa5f31