Add pref to modify the timing to display the visual warning for long transaction

RESOLVED FIXED in Firefox 38

Status

()

Core
Graphics: Layers
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: pchang, Assigned: pchang)

Tracking

Trunk
mozilla38
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox38 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
The timing to display the visual warning for long transaction is 200 ms and the long transaction usually happens because of the time cost for content rendering. Adding the preference to customize the timing can help us to detect some apps that spend time more than 16 ms but less than 200 ms.
(Assignee)

Comment 1

3 years ago
BTW, I think it is also useflu to dump the child process id when the long transaction happens, especially the app switches in b2g.
(Assignee)

Comment 2

3 years ago
Created attachment 8559626 [details] [diff] [review]
Add pref for the threshold of frame visual warning
Assignee: nobody → pchang
Status: NEW → ASSIGNED
Attachment #8559626 - Flags: review?(bgirard)
Comment on attachment 8559626 [details] [diff] [review]
Add pref for the threshold of frame visual warning

Review of attachment 8559626 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/LayerTransactionParent.cpp
@@ +625,5 @@
> +        severity = 1.f;
> +      }
> +      mLayerManager->VisualFrameWarning(severity);
> +#ifdef PR_LOGGING
> +      PR_LogPrint("LayerTransactionParent::RecvUpdate transaction from process %d took %f ms %p",

Looks like you have an extra %p.

::: gfx/thebes/gfxPrefs.h
@@ +277,5 @@
>    DECL_GFX_PREF(Live, "layers.dump-decision",                  LayersDumpDecision, bool, false);
>    DECL_GFX_PREF(Live, "layers.dump-client-layers",             DumpClientLayers, bool, false);
>    DECL_GFX_PREF(Live, "layers.dump-host-layers",               DumpHostLayers, bool, false);
>  #endif
> +  DECL_GFX_PREF(Live, "layers.transaction.warning_ms",         LayerTransactionWarning, uint32_t, 200);

warning-ms to be consistent with the layers.* preferences
Attachment #8559626 - Flags: review?(bgirard) → review+
(Assignee)

Comment 4

3 years ago
Created attachment 8560274 [details] [diff] [review]
Add pref for the threshold of frame visual warning v2

Update patch to address reviewer's comment.
Attachment #8559626 - Attachment is obsolete: true
Attachment #8560274 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/319575fa5f31
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.