1129770 - Deprecated.jsm can log "null 0 null" as part of it's stack trace

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

This is minor, but... I just had Deprecated.jsm log a stack trace that included "null 0 null" as the last frame. Would be nice to have some check to avoid that, as it's just noise.

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Needs a check here:
https://dxr.mozilla.org/mozilla-central/source/toolkit/modules/Deprecated.jsm#29

I *think* any one of those can be null, so the check should probably be:
  fileName==null && lineNumber==0 && name==null

Comment 2

[Marco Bonardo [:mak]]

Can add a check here https://searchfox.org/mozilla-central/rev/45e308665eb9fc52fd21e2d4b3b959f3cec13ef1/toolkit/modules/Deprecated.jsm#39 to ensure at least one of the printed entries is notnull.

Comment 3

[sirri]

Attachment: Bug 1129770 - Deprecated.jsm can log 'null 0 null' as part of it's stack trace. r=mak

Bug 1129770 - Deprecated.jsm can log 'null 0 null' as part of it's stack trace. r=mccr8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52ec76164dcf
Deprecated.jsm can log 'null 0 null' as part of it's stack trace. r=mak

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/52ec76164dcf