Closed Bug 1129770 Opened 7 years ago Closed 29 days ago

Deprecated.jsm can log "null 0 null" as part of it's stack trace

Categories

(Toolkit :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
96 Branch
Tracking Status
firefox96 --- fixed

People

(Reporter: Unfocused, Assigned: sirrichi98, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(1 file)

This is minor, but... I just had Deprecated.jsm log a stack trace that included "null 0 null" as the last frame. Would be nice to have some check to avoid that, as it's just noise.

Can add a check here https://searchfox.org/mozilla-central/rev/45e308665eb9fc52fd21e2d4b3b959f3cec13ef1/toolkit/modules/Deprecated.jsm#39 to ensure at least one of the printed entries is notnull.

Mentor: blair → mak
Keywords: good-first-bug
Whiteboard: [lang=js]

Bug 1129770 - Deprecated.jsm can log 'null 0 null' as part of it's stack trace. r=mccr8

Assignee: nobody → sirrichi98
Status: NEW → ASSIGNED
Attachment #9249606 - Attachment description: Bug 1129770 - Deprecated.jsm can log 'null 0 null' as part of it's stack trace. r=mccr8 → Bug 1129770 - Deprecated.jsm can log 'null 0 null' as part of it's stack trace. r=mak
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/52ec76164dcf
Deprecated.jsm can log 'null 0 null' as part of it's stack trace. r=mak
Status: ASSIGNED → RESOLVED
Closed: 29 days ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.