1129791 - Incorrect comparison in nricectx.cpp

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect)

Description

[Martin Thomson [:mt:]]

Here: https://dxr.mozilla.org/mozilla-central/source/media/mtransport/nricectx.cpp#671

This should probably be checking connection_state_ rather than ctx_->state, which only coincidentally has the value.

Now, I did run into this assertion once, and it's not clear that there isn't some other problem in there, but a fix here should at least help.

Comment 1

[Martin Thomson [:mt:]]

Attachment: MozReview Request: bz://1129791/mt

/r/3377 - Bug 1129791 - Checking connection state rather than context state

Pull down this commit:

hg pull review -r e5524456af3b9d7c0f109b4633bb29068c92cf31

Comment 2

[Martin Thomson [:mt:]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c38b80b52cfa

Comment 3

[Eric Rescorla (:ekr)]

Comment on attachment 8559607 [details]
MozReview Request: bz://1129791/mt

https://reviewboard.mozilla.org/r/3375/#review2739

Ship It!

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/88a56d5d34e9

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/88a56d5d34e9

Comment 7

[Martin Thomson [:mt:]]

Attachment: MozReview Request: Bug 1129791 - Checking connection state rather than context state