1129814 - [PTS][Certification]+CLIP AT command replied incorrect currupt string

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

- AT: Service Level Connection established
	- AT: post SLC command sequence complete
	- AT: RING
	- FATAL ERROR (AT): +CLIP contains incorrect phone number: "0????S??int"  expected: "0939835820".  Check TSPX_phone_number
	- MTC received unexpected EXIT message from AT component
	- AT: Received +CLIP: "0????S??int",129




	132	Slave	46	AT+CLIP=1.	Enable CLI notofication			22	 00:00:00.000000	2015/2/5 下午 04:16:11.121000	
	134	Master	46	..OK..			Success	19	 00:00:00.010000	2015/2/5 下午 04:16:11.131000	
	135	Slave	46	AT+CCWA=1.	Enable call waiting notification			22	 00:00:00.000000	2015/2/5 下午 04:16:11.131000	
	137	Master	46	..OK..			Success	19	 00:00:00.010000	2015/2/5 下午 04:16:11.141000	
	138	Slave	46	AT+CMEE=1.	Enable Extended Audio Gateway Error Result Code			22	 00:00:00.000000	2015/2/5 下午 04:16:11.141000	
	140	Master	46	..OK..			Success	19	 00:00:00.010000	2015/2/5 下午 04:16:11.151000	
	143	Master	46	..+CIEV: 2,1..		Call Setup indicator's status report		26	 00:00:25.728000	2015/2/5 下午 04:16:36.879000	
	144	Master	46	..RING..		Incoming Call/Call progress indication		20	 00:00:00.005000	2015/2/5 下午 04:16:36.884000	
	145	Master	46	..+CLIP: "0....S..int",129..	+CLIP: "0黃S紫int",129			40	 00:00:00.000000	2015/2/5 下午 04:16:36.884000	
	147	Slave	46	ATA.		Answer mode		16	 00:00:00.025000	2015/2/5 下午 04:16:36.909000	
	149	Master	46	..OK..			Success	19	 00:00:00.015000	2015/2/5 下午 04:16:36.924000

Comment 1

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

We need to verify that clcc_response api correctly handle call number.
CLIP AT command was handle by bluedroid but we need to check that we pass the correct value to stack.

Comment 2

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

I can reproduce this bug on nexus5-l

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

It looks like |phone_state_change| |number| parameter is invalid.

Comment 4

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

This can blocked many PTS HFP phone call test cases because PTS will verify call numbers.

Comment 5

[howie [:howie]]

Triage: blocking

Comment 6

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

We have investigated this bug. We dumped PDU sent from Gecko, nothing is wrong. Thanks for :brsun, we found the problem is from bluetoothd, 0-terminated string handling. We expected this will be resolved next week.

Comment 7

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Transfer to :brsun, he found the solution. This blocker will be updated and resolved next week work day.

Comment 8

[Bruce Sun [:brsun]]

Attachment: https://github.com/mozilla-b2g/platform_system_bluetoothd/pull/20

Comment 9

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8561204 [details] [review]
https://github.com/mozilla-b2g/platform_system_bluetoothd/pull/20

This looks good. Thank you for fixing this bug.

Comment 10

[Thomas Zimmermann [:tzimmermann] [:tdz]]

BTW, could you update the copyright message at the top as well? IIRC It says '2014  Mozilla...' and since you touched the file that should now be '2014-2015  Mozilla...'.

Comment 11

[Bruce Sun [:brsun]]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #10)
> BTW, could you update the copyright message at the top as well? IIRC It says
> '2014  Mozilla...' and since you touched the file that should now be
> '2014-2015  Mozilla...'.

Done.

Comment 12

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Wait a second. There are now 3 commits. Two with code and a merge commit. Please remove the merge and just use a single commit for the fix.

Comment 13

[Bruce Sun [:brsun]]

Comment on attachment 8561204 [details] [review]
https://github.com/mozilla-b2g/platform_system_bluetoothd/pull/20

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Regular PTS fails due to memory corruption.
Testing completed: Manual local testing.
Risk to taking this patch (and alternatives if risky): Low. This patch is very small and is just used to fix memory corruption.
String or UUID changes made by this patch: N/A.

Comment 14

[Bruce Sun [:brsun]]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #12)
> Wait a second. There are now 3 commits. Two with code and a merge commit.
> Please remove the merge and just use a single commit for the fix.

Thanks. I'm going to handle this.

Comment 15

[Bruce Sun [:brsun]]

Comment on attachment 8561204 [details] [review]
https://github.com/mozilla-b2g/platform_system_bluetoothd/pull/20

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Regular PTS fails due to memory corruption.
Testing completed: Manual local testing.
Risk to taking this patch (and alternatives if risky): Low. This patch is very small and is just used to fix memory corruption.
String or UUID changes made by this patch: N/A.

Comment 16

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Just another nit for future patches: when you create patches for bluetoothd, please add the bug number to each commit summary; like for Gecko patches.

Comment 17

[Bruce Sun [:brsun]]

Done.

Comment 18

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Bruce, can you please recreate the pull request on the latest b2g/master?

The pull request for bug 1129257 messed up commit history with broken and merge commits. I fixed this up in current master.

Comment 19

[Bruce Sun [:brsun]]

Attachment: https://github.com/mozilla-b2g/platform_system_bluetoothd/pull/24

Thanks Thomas, Ben, Shawn. A new PR has been created for review again.

Comment 20

[bhavana bajaj [:bajaj]]

waiting for master landing before getting to branch approval.

Comment 21

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8562515 [details] [review]
https://github.com/mozilla-b2g/platform_system_bluetoothd/pull/24

Thank you!

master: https://github.com/mozilla-b2g/platform_system_bluetoothd/commit/b2da0cc9c1ebf976954398eb65aa9243ab7b000f

Comment 22

[Bruce Sun [:brsun]]

Comment on attachment 8562515 [details] [review]
https://github.com/mozilla-b2g/platform_system_bluetoothd/pull/24

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Regular PTS fails due to memory corruption.
Testing completed: Manual local testing.
Risk to taking this patch (and alternatives if risky): Low. This patch is very small and is just used to fix memory corruption.
String or UUID changes made by this patch: N/A.

Comment 23

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/platform_system_bluetoothd/commit/02e006438ce45b9eb36bc7c875130941276a9c08