1129816 - [Loop] Room can't be saved When the call has the maximum length allowed in subject

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Loli (:lolimartinezcr)]

Attachment: 2015-02-05-09-17-12.png

Fire E 2.0
Loop 1.1.1/bd1a553

Prerequisites:
1. User A logged in Mobile Loop application with FxA
2. User A has contact B saved.
3. Contact B isn't logged in Mobile Loop application

STRs:
1. User A clicks in "New call" button.
2. User A writes subject with maximum lenght allowed and taps on "call" button.
3. After a few seconds "Dialing", user A sees "Unavailable" status.
4. User A taps on "New room"

Actual result:
"Saving room failed" message is shown. See attached image.
I think the problem maximum lenght allowed in calls is 124 characters in subject and in room has 100 characters allowed

Expected result:
Room should be saved.

Comment 1

[Cristian Rodriguez (:crdlc)]

Good catch

E/GeckoConsole(18123): Content JS ERROR at app://loop.stage.mozaws.net/js/screens/create_room.js:151 in newRoom/<: {"code":400,"errno":107,"error":"roomName should be shorter than 100 characters"}

So we have two solutions:

1) Same limit for calls and rooms (100 chars)
2) Limit the call subject to 100 when it is longer behind scene in the fallback scenario

Comment 2

[Maria Angeles Oteo (:oteo)]

I would say option 2; in case of creating the new Room in the fallback scenario, I think it makes sense limit the Room name to 100 characters.

Comment 3

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8559665 [details] [review]
Github pull request

LGTM, r=me

Clean and safe, thanks for taking care of it Cristian!

Comment 5

[Cristian Rodriguez (:crdlc)]

master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/769be9c323d3439d30627ce517ecb80f2caf167d

Comment 6

[Maria Angeles Oteo (:oteo)]

As the last Telemetry patch has already been uplifted to 1.1.1 branch, let's merge this patch to 1.1.1 branch now.
Thanks a lot Cristian!!

Comment 7

[Cristian Rodriguez (:crdlc)]

in 1.1.1

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/4f9651c9b9ed64b33fee952dbf73fbbe7fa3325b

Comment 8

[Javier de Prado]

Verified on fireE, v2.0 comercial version.
Loop version 1.1.1/39a5284