1129868 - [Loop] Delete button is always shown also when the user deleted the room

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[mbarone]

Device: Flame and Fire E v2.0
FxHello v1.1.1/bd1a553

Pre-condition: User A has created a room and shared it with user B

STR
1. User A removes the room
2. User B, on Room list, taps on the room shared by A (ER1)
3. User B taps on Delete (ER2)
4. Repeat from step 1, now on step 3, User B taps on Delete (ER3)

ACTUAL RESULT
ER1. User B will see a message: Oops... You can't join because the room is not longer available. It may be expired or deleted.
Do you want to delete it from your room list? 

ER2. In case option "Delete" is pressed, the room will be deleted (not necessary to show the banner in this case) and we go back to the Room list

ER3. The same message of ER1 is shown and the user can delete again the room deleted on step 3

EXPECTED RESULT ER3
The room was delete, so the user should not have the option to delete the room again and again.

Comment 1

[mbarone]

Replace Step 4. The user B joins the room again using the link shared by user A to user B

Comment 2

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8559758 [details] [review]
Github pull request

LGTM, r=me with a nit I left addressed.

Thanks Cristian!

Comment 4

[Maria Angeles Oteo (:oteo)]

I think is a little confusing the message. 

If the room has already been deleted from the Room list, I would not include the sentence "Do you want to delete it from your room list?"

Besides, I am not sure if it's better "Cancel" or "OK" button.

Before landing this, let's set ni to Monica to confirm it.

Comment 5

[Cristian Rodriguez (:crdlc)]

ok but remember the lang issues in this point, German for instance if we have to include a new string in 1.1.1

Comment 6

[Maria Angeles Oteo (:oteo)]

(In reply to Cristian Rodriguez (:crdlc) from comment #5)
> ok but remember the lang issues in this point, German for instance if we
> have to include a new string in 1.1.1

that's true, in that case, it'd better not uplifting it to 1.1.1 branch for now

Comment 7

[Cristian Rodriguez (:crdlc)]

(In reply to Maria Angeles Oteo (:oteo) from comment #4)
> I think is a little confusing the message. 
> 
> If the room has already been deleted from the Room list, I would not include
> the sentence "Do you want to delete it from your room list?"
> 
> Besides, I am not sure if it's better "Cancel" or "OK" button.
> 
> Before landing this, let's set ni to Monica to confirm it.

Implemented. I just added a new string for all languages removing the last question related to "delete the room". Also changed the "cancel" button for "OK"

Comment 8

[Cristian Rodriguez (:crdlc)]

Attachment: Asking for removing (cancel | remove)

Comment 9

[Cristian Rodriguez (:crdlc)]

Attachment: With question about removing

Comment 10

[Cristian Rodriguez (:crdlc)]

Attachment: without question (OK)

Comment 11

[Mónica UX/UI]

Hey!!
Yeah, I think that [OK] it's perfect :)
Thanks!

Comment 12

[Cristian Rodriguez (:crdlc)]

master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/549cf30a63360034f5580bddf4d788f3b0d999f6