Closed
Bug 1129885
Opened 10 years ago
Closed 10 years ago
[Loop] User (logged with MobileID) is logged out of the Loop application.
Categories
(Firefox OS Graveyard :: Gaia::Loop, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: lolimartinezcr, Assigned: jaoo)
Details
(Whiteboard: [Room1.1.1_Regression2][loop approved for 1.1.1][In 1.1.1])
Attachments
(1 file)
Fire E 2.0 Loop 1.1.1/bd1a553 Prerequisites: Previously user A has been logged in Mobile Loop application with FxA. STRs: 1. User A taps settings in Loop application. 2. User A taps on "Log out" button. 3. User A taps Loop application. 4. User A taps on "Use phone number" button. 5. User A writes phone number. 6. User A taps on "Share" and "Verify" buttons. 7. User A taps on "home" button. 8. User A taps on Settings. 9. User A taps on "Firefox Accounts" option. 10. User A taps on "Sign Out" button and taps on "<". 11. User A taps on "home" button 12. User A taps on "Loop" application. Actual result: User A (logged with MobileID) has been logged out. Expecte result: User A (logged with MobileID) shouldn't be logged out.
Reporter | ||
Updated•10 years ago
|
Whiteboard: [Room1.1.1_Regression2]
Assignee | ||
Comment 1•10 years ago
|
||
The issue reproduces as It is detailed in the STR above. I'm not sure this issues is new It might be present from the beginning. Having a look at it.
Assignee: nobody → josea.olivera
Status: NEW → ASSIGNED
Comment 2•10 years ago
|
||
I am able to reproduce it also with the already delivered 1.1 version
Assignee | ||
Comment 3•10 years ago
|
||
Borja, would you mind to review this please? Thanks!
Attachment #8559802 -
Flags: review?(borja.bugzilla)
Comment 4•10 years ago
|
||
Comment on attachment 8559802 [details] [review] Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/560 Great job!
Attachment #8559802 -
Flags: review?(borja.bugzilla) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Landed on master branch at: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/99272f6eff8914625ac0c37e2283b35811a40f26 Really good catch Loli. Thanks for filing this up.
Whiteboard: [Room1.1.1_Regression2] → [Room1.1.1_Regression2][Not in 1.1.1]
Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 6•10 years ago
|
||
As the last Telemetry patch has already been uplifted to 1.1.1 branch, let's merge this patch to 1.1.1 branch now. Thanks a lot Jose Antonio!!
Flags: needinfo?(josea.olivera)
Whiteboard: [Room1.1.1_Regression2][Not in 1.1.1] → [Room1.1.1_Regression2][Not in 1.1.1][loop approved for 1.1.1]
Assignee | ||
Comment 7•10 years ago
|
||
Landed in 1.1.1 branch at: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/0613af9d0ede8e3424b3018320213051b252dc6a
Flags: needinfo?(josea.olivera)
Whiteboard: [Room1.1.1_Regression2][Not in 1.1.1][loop approved for 1.1.1] → [Room1.1.1_Regression2][loop approved for 1.1.1][In 1.1.1]
Comment 8•10 years ago
|
||
Verified on fireE, v2.0 comercial version. Loop version 1.1.1/39a5284
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•