Closed Bug 1129923 Opened 9 years ago Closed 9 years ago

Remove nonstandard let blocks from the DOM Inspector

Categories

(Other Applications :: DOM Inspector, defect)

Product:
Other Applications
Component:
DOM Inspector
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: philip.chee, Assigned: philip.chee)

References

Details

Attachments

(1 file)

hg qdiff -w
3.01 KB, patch
neil
: review+
Details | Diff | Splinter Review 
      No description provided.
Attached patch hg qdiff -w — — Splinter Review 
Thu Feb 05 2015 21:39:11
Warning: JavaScript 1.7's let blocks are deprecated
Source file: chrome://inspector/content/viewers/dom/dom.js
Line: 1071

let blocks are a nonstandard SpiderMonkey feature we would like to remove (in bug 1023609). This patch removes the let blocks in the DOM Inspector. The attached patch excludes whitespace changes because most of the patch is unindenting blocks of unchanged code from the removed let blocks.
Comment on attachment 8559790 [details] [diff] [review]
hg qdiff -w

NB: diff -w patch
Attachment #8559790 - Flags: review?(neil)
Comment on attachment 8559790 [details] [diff] [review]
hg qdiff -w

>+let commands = BindingsListController.prototype.commands;
...
>+let commands = ResourceTreeController.prototype.commands;
Nit: technically this is a redeclaration.
Attachment #8559790 - Flags: review?(neil) → review+
Pushed to dom-inspector
http://hg.mozilla.org/dom-inspector/rev/8c6a6ec9a22c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.