1129930 - JavaScript error: chrome://browser/content/preferences/in-content/preferences.js, line 82: TypeError: getComputedStyle(...) is null

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[:Gijs (he/him)]

STR:

./mach mochitest-browser browser/components/preferences/in-content/tests

throws lots of these.

I bet that the element is gone before init() runs, which then breaks stuff.

We should probably nullcheck it in the code, and stick it in a separate method while we're at it (the latter was something I meant to give as feedback in bug 1126278 and forgot about - sorry).

Ian, do you have cycles to work on this?

Comment 1

[Ian Moody [:Kwan] (UTC+1)]

Attachment: Move padding code into function, and execute before the CustomEvent

Comment 2

[:Gijs (he/him)]

Comment on attachment 8559882 [details] [diff] [review]
Move padding code into function, and execute before the CustomEvent

Review of attachment 8559882 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[Ian Moody [:Kwan] (UTC+1)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d890bb4aec9
5 intermittent oranges, and a couple infra issues that went away on retrigger.  I think that makes it green enough to checkin

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/f6d265d88cb4

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f6d265d88cb4