Closed
Bug 1129946
Opened 10 years ago
Closed 10 years ago
[STK] Add result code for "command performed successfully, but requested icon could not be displayed"
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(blocking-b2g:2.1S+, firefox36 wontfix, firefox37 wontfix, firefox38 fixed, b2g-v2.1 fixed, b2g-v2.1S fixed, b2g-v2.2 fixed, b2g-master fixed)
People
(Reporter: edgar, Assigned: edgar)
References
Details
(Whiteboard: [sprd390581])
Attachments
(1 file)
1.45 KB,
patch
|
hsinyi
:
review+
bajaj
:
approval-mozilla-b2g34+
bajaj
:
approval-mozilla-b2g37+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1117663 +++
In 11.14, clause 6.5.4 and clause 12.12
--
If the SIM provides an icon identifier with a proactive command, then the ME shall inform the SIM if the icon could not be displayed by sending the general result "Command
performed successfully, but requested icon could not be displayed"
--
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8559837 [details] [diff] [review]
Patch, v1
Review of attachment 8559837 [details] [diff] [review]:
-----------------------------------------------------------------
Hi Hsinyi, may I have your review? Thank you.
Attachment #8559837 -
Flags: review?(htsai)
Comment 4•10 years ago
|
||
Comment on attachment 8559837 [details] [diff] [review]
Patch, v1
Review of attachment 8559837 [details] [diff] [review]:
-----------------------------------------------------------------
Thank you!
Attachment #8559837 -
Flags: review?(htsai) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Assignee | ||
Comment 6•10 years ago
|
||
Comment 7•10 years ago
|
||
Updated•10 years ago
|
Flags: needinfo?(chens)
Comment 8•10 years ago
|
||
Hi Edgar, would you request approval to uplift this patch to 2.1? thanks!
Flags: needinfo?(chens) → needinfo?(echen)
Comment 9•10 years ago
|
||
Hi Steven,
You may want to triage this for 2.1S.
Additional kind information, this bug isn't shown in the mana 2.1S? list. Something may be wrong in the search criteria.
Flags: needinfo?(styang)
Assignee | ||
Comment 10•10 years ago
|
||
(In reply to Sherman Chen [:chens] from comment #8)
> Hi Edgar, would you request approval to uplift this patch to 2.1? thanks!
Hi Steven, do you think it is worth uplifting to 2.1 or 2.2 as well?
Flags: needinfo?(echen)
Comment 11•10 years ago
|
||
Take it for 2.1S. As for 2.1 or 2.2, I will leave it to drivers. please put it into 2.1S first.
blocking-b2g: 2.1S? → 2.1S+
Flags: needinfo?(styang)
Assignee | ||
Comment 12•10 years ago
|
||
Hi :seinlin, would you mind helping to uplift patch to 2.1S, thank you.
Flags: needinfo?(kli)
Comment 13•10 years ago
|
||
status-b2g-v2.1S:
--- → fixed
Flags: needinfo?(kli)
Assignee | ||
Comment 14•10 years ago
|
||
Comment on attachment 8559837 [details] [diff] [review]
Patch, v1
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.
[Approval Request Comment]
Bug caused by (feature/regressing bug #): feature
User impact if declined: Test case fail: [STK] USAT case 27.22.4.1.5 DISPLAY TEXT SEQ 5.1 display of basic icon
Testing completed: Partner tested PASS.
Risk to taking this patch (and alternatives if risky): Very low because it is only added a new result code 0x04.
String or UUID changes made by this patch: None
Attachment #8559837 -
Flags: approval-mozilla-b2g34?
Assignee | ||
Comment 15•10 years ago
|
||
Comment on attachment 8559837 [details] [diff] [review]
Patch, v1
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.
[Approval Request Comment]
Bug caused by (feature/regressing bug #): feature
User impact if declined: Test case fail: [STK] USAT case 27.22.4.1.5 DISPLAY TEXT SEQ 5.1 display of basic icon
Testing completed: Partner tested PASS.
Risk to taking this patch (and alternatives if risky): Very low because it is only added a new result code 0x04.
String or UUID changes made by this patch: None
Attachment #8559837 -
Flags: approval-mozilla-b2g37?
Updated•10 years ago
|
Attachment #8559837 -
Flags: approval-mozilla-b2g37?
Attachment #8559837 -
Flags: approval-mozilla-b2g37+
Attachment #8559837 -
Flags: approval-mozilla-b2g34?
Attachment #8559837 -
Flags: approval-mozilla-b2g34+
Comment 16•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/e969ac9790e6
https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ca67e5b5d81b
status-b2g-v2.1:
--- → fixed
status-b2g-v2.2:
--- → fixed
status-b2g-master:
--- → fixed
status-firefox36:
--- → wontfix
status-firefox37:
--- → wontfix
Target Milestone: --- → 2.2 S6 (20feb)
You need to log in
before you can comment on or make changes to this bug.
Description
•