Closed Bug 1129976 Opened 9 years ago Closed 9 years ago

Add regions for dsb and hsb in product-details

Categories

(www.mozilla.org :: Product Details, defect)

Product:
www.mozilla.org
Component:
Product Details
Version:
Development/Staging
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: flod, Assigned: pascalc)

Details

Noticed while setting up new locales (dsb, hsb)
https://www-dev.allizom.org/dsb/contribute/signup/
https://www-dev.allizom.org/hsb/contribute/signup/

Is this a Django limitation? I wonder if we can at least mitigate the issue by falling back to a different locale.

Not a blocker at the moment since we're not shipping the new form for localized pages.
It's a limitation of product-details. If we have those translations, we'd just need to get them added to product-details (http://viewvc.svn.mozilla.org/vc/libs/product-details/regions/). If that's not likely, then we can indeed decide on a "best fallback" and have that displayed instead of the english.
Thanks, didn't realize they were coming from us. It should be fixable by updating product-details then.
This data comes from Firefox source code, we can definitely update product-details view Transvision API
s/view/via
If I understand this old bug correctly (bug 653435), it should be enough to copy the entire file, strip the license header, and rename them to (locale).properties?

http://hg.mozilla.org/releases/l10n/mozilla-aurora/dsb/file/default/toolkit/chrome/global/regionNames.properties
http://hg.mozilla.org/releases/l10n/mozilla-aurora/hsb/file/default/toolkit/chrome/global/regionNames.properties
(In reply to Francesco Lodolo [:flod] from comment #5)
> If I understand this old bug correctly (bug 653435), it should be enough to
> copy the entire file, strip the license header, and rename them to
> (locale).properties?
> 
> http://hg.mozilla.org/releases/l10n/mozilla-aurora/dsb/file/default/toolkit/
> chrome/global/regionNames.properties
> http://hg.mozilla.org/releases/l10n/mozilla-aurora/hsb/file/default/toolkit/
> chrome/global/regionNames.properties

Yes
Component: L10N → Product Details
Summary: List of countries in /contribute new form is not localized for some locales (dsb, hsb) → Add regions for dsb and hsb in product-details
Moving to the right component then (I don't have access to that repo as far as I know).
Pascal, is this something you can fix?
Flags: needinfo?(pascalc)
Assignee: nobody → pascalc
Flags: needinfo?(pascalc)
done in r139242
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Thank you, Francesco, thank you Pascal.
It looks correct now
https://www-dev.allizom.org/dsb/contribute/signup/

I assume this will be pushed to prod by release drivers?
I believe bedrock updates product details data every time there is a push to prod.
Perfect! It works now. Thank you once more.
You need to log in before you can comment on or make changes to this bug.