Unhandled IRC message 470: Channel redirect

RESOLVED FIXED in 1.6

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: aleth, Assigned: aleth)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

STR: /join #webrtc on moznet, and interesting things happen:
- Broken #webrtc tab with endless throbber
- #media tab in the 'left' state.

[05/02/2015 18:31:57] 	WARN. (@ prpl-irc: ircSocket.prototype.onDataReceived resource://gre/components/irc.js:685)
Unhandled IRC message:
:fripp.mozilla.org 470 aleth #webrtc #media :You may not join this channel, so you are automatically being transferred to the redirect channel.
[05/02/2015 18:31:57] 	DEBUG (@ prpl-irc: ircSocket.prototype.onDataReceived resource://gre/components/irc.js:681)
{"rawMessage":":aleth!instantb@moz-7em4hk JOIN :#media","command":"JOIN","params":["#media"],"origin":"aleth","user":"instantb","host":"moz-7em4hk","source":"instantb@moz-7em4hk"}
[05/02/2015 18:31:57] 	WARN. (@ prpl-irc: ircBase.commands.JOIN resource://gre/modules/ircBase.jsm:215)
Opening a MUC without storing its prplIChatRoomFieldValues first.
...
That's totally not in RFC 2812...

WebRTC isn't a public channel? That's surprising. Looks like we need to specifically handle this though.
Posted patch irc470.diffSplinter Review
Easily fixed.
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Attachment #8559931 - Flags: review?(clokep)
Comment on attachment 8559931 [details] [diff] [review]
irc470.diff

Review of attachment 8559931 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! You don't need another review.

::: chat/protocols/irc/ircNonStandard.jsm
@@ +175,5 @@
>               aMessage.params[1] == "Password required";
>      },
>  
> +    "470": function(aMessage) {
> +      // Channel forward (Unreal, inspircd)

Stupid nit: Put this on the end of the line above to match the other statements in this file.
Attachment #8559931 - Flags: review?(clokep) → review+
https://hg.mozilla.org/comm-central/rev/e23ce66b53ef
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in before you can comment on or make changes to this bug.