Closed Bug 1130117 Opened 10 years ago Closed 10 months ago

rename StringBuffer::append to StringBuffer::appendLatin1

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: tromey, Unassigned)

References

Details

In the review for bug 987069, Waldo asked me to rename StringBuffer::append(const char*) to StringBuffer::appendLatin1. He suggested that 987069 be finished first.
I took a quick look at this. It's not a simple renaming. In some cases, the "append" overload is made use of via templates. For example: https://dxr.mozilla.org/mozilla-central/source/js/src/jsstr.cpp?from=jsstr.cpp#2777

I suspect this isn't relevant any more now that bug 987069 is closed.

Assignee: tom → nobody
Severity: normal → S3
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.