1130181 - Multi-size .ico Image not supported in OpenSearch

Status: RESOLVED INVALID

(Firefox :: Search, defect)

Description

[Brandon Frohs]

Attachment: pd-multiple.ico

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20150125222008

Steps to reproduce:

1. Add <link rel="search" type="application/opensearchdescription+xml" href="open.xml" title="Search"> to page
2. Upload `open.xml`
3. Upload `pd-multiple.ico`
4. Attempt to add site search to Firefox


Actual results:

Site search item uses placeholder icon.


Expected results:

Site search item should use `pd-multiple.ico` (choosing the appropriate size).

Comment 1

[Brandon Frohs]

Attachment: pd-single.ico

Single image .ico works fine.

Comment 2

[Brandon Frohs]

Attachment: open.xml

Comment 3

[Brandon Frohs]

Attachment: pd.svg

.ico files created with `convert` from ImageMagick:

convert -alpha on -channel RGBA -density 500 -background none -gravity center pd.svg \
	\( -clone 0 -resize 16x16 -extent 16x16 \) \
	-delete 0 pd-single.ico;

convert -alpha on -channel RGBA -density 500 -background none -gravity center pd.svg \
	\( -clone 0 -resize 256x256 -extent 256x256 \) \
	\( -clone 0 -resize 128x128 -extent 128x128 \) \
	\( -clone 0 -resize 64x64 -extent 64x64 \) \
	\( -clone 0 -resize 48x48 -extent 48x48 \) \
	\( -clone 0 -resize 32x32 -extent 32x32 \) \
	\( -clone 0 -resize 16x16 -extent 16x16 \) \
	-delete 0 pd-multiple.ico;

Comment 4

[Matthew N. [:MattN]]

Hmm… this should have worked in 35 if the image URL ended with ".ico" and bug 1163559 fixed it so the query string doesn't interfere (the file extension needs to be .ico) and data URIs with relevant ICO mimetypes work.

Are you sure this is related to the multiple resolutions? Is this still a problem on newer Firefox?

Comment 5

[Brandon Frohs]

(In reply to Matthew N. [:MattN] from comment #4)
> Are you sure this is related to the multiple resolutions?

I'm assuming that's the issue, but I'm not positive. The only difference needed to get this bug to appear is using pd-multiple.ico instead of pd-single.ico. If it isn't due to multi-size, it's due to a difference between those files. (Which were created using the code in comment 3.)

> Is this still a problem on newer Firefox?

Yes, verified in 41.0a2 (2015-07-27) on Ubuntu using the steps in comment 1.

Interestingly, the icon next to 'Add "SEARCHNAME"' works properly, but the icon in the list of search engines once it's added is still the placeholder icon.

Comment 6

[Dave Townsend [:mossop]]

The search service imposes a 10,000 byte limit on the size of icons. The multiple resolution icon is over 361kb so it is ignored.