1130258 - Avoid closing wrong Text Selection

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[Mark Capella [:capella]]

The TextSelection.java actionbar always sends a "TextSelection:End" message to SelectionHandler.js when it closes, even when triggered to close by a "TextSelection:HideHandles" message from SelectionHandler.js in the first place.

(vs. user clicking the checkMark in the actionbar, for example).

It's possible that SelectionHandler.js can close a selection then quickly open a new one, and when it finally hears the initial "TextSelection:End" message loop back, it closes its new selection.

STR: Close FF and open clean.
Navigate to http://en.m.wikipedia.org/wiki/Mozilla
Long press "community" in the first paragraph to selectWord and open actionbar
Tap the selectAll icon in the actionBar
Observe that the entire page is selected, then actionbar closes and
   selection is lost.

Comment 1

[Mark Capella [:capella]]

Attachment: bug1130258.diff

Simple fix, but test-infra needs mostly cut/paste updates.

Comment 2

[Mark Capella [:capella]]

Review ping? Or, quick feedback?

Comment 3

[Wesley Johnston (:wesj)]

Comment on attachment 8560235 [details] [diff] [review]
bug1130258.diff

Review of attachment 8560235 [details] [diff] [review]:
-----------------------------------------------------------------

Hmm... Not my favorite way to do this, but I think it will work. Lets try.

::: mobile/android/chrome/content/SelectionHandler.js
@@ +788,5 @@
>        // Ensure targetElement is now focused normally
>        aElement.focus();
>      }
>  
> +    this._selectionID++;

I sorta prefer using GUID's to these counters, but I have no good reason for it (maybe someday we have two windows open and these ID's would interfere, but that's a long ways off...). Lets try this.

Comment 4

[Mark Capella [:capella]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5c3ea5144697

Comment 5

[Mark Capella [:capella]]

https://hg.mozilla.org/integration/fx-team/rev/dab5ffb04992

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dab5ffb04992