Closed Bug 1130259 Opened 5 years ago Closed 5 years ago

Integer overload of scrollBy recursively calls itself instead of calling the double overload

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox35 --- unaffected
firefox36 + fixed
firefox37 + fixed
firefox38 + fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

Thanks to Chris Peterson for spotting this.  We should fix this on 36, because otherwise binary extensions might run into this problem and crash.
Also, let me know if you prefer "r=kgilbert" to "r=kip", ok?
Comment on attachment 8560250 [details] [diff] [review]
Make sure the integer overload of ScrollBy calls the double one, not itself

Review of attachment 8560250 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, thanks for spotting it.

Also, "r=kip" might be easiest for people that are trying to find me on irc by that handle.
Attachment #8560250 - Flags: review?(kgilbert) → review+
Tracking for 36+ based on comment 0. Given that there is already a patch, let's try to get this into Beta 8, which goes to build on Monday.
Comment on attachment 8560250 [details] [diff] [review]
Make sure the integer overload of ScrollBy calls the double one, not itself

Approval Request Comment
[Feature/regressing bug #]: Bug 1045754 
[User impact if declined]: Some binary extensions may end up with stack-overflow
   crashes if they try to scroll windows from c++.
[Describe test coverage new/current, TreeHerder]: None, sadly.
[Risks and why]: Risk is very very low.
[String/UUID change made/needed]: None.
Attachment #8560250 - Flags: approval-mozilla-beta?
Attachment #8560250 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/271298feef37
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Attachment #8560250 - Flags: approval-mozilla-beta?
Attachment #8560250 - Flags: approval-mozilla-beta+
Attachment #8560250 - Flags: approval-mozilla-aurora?
Attachment #8560250 - Flags: approval-mozilla-aurora+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.