1130268 - NameError: global name 'proc' is not defined in runreftest.py.

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[Tooru Fujisawa [:arai]]

Similar issue in bug 1117631.

https://hg.mozilla.org/mozilla-central/file/68a47aac2628/layout/tools/reftest/runreftest.py#l397
https://hg.mozilla.org/mozilla-central/file/68a47aac2628/layout/tools/reftest/runreftest.py#l403

>  def killAndGetStack(self, process, utilityPath, debuggerInfo, dump_screen=False):
>  ...
>          proc.kill(sig=signal.SIGABRT)
>  ...
>    proc.kill()

they should be "process".

Comment 1

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/mozilla-central/file/68a47aac2628/layout/tools/reftest/runreftest.py#l392

>          printstatus(status, "crashinject")

Also, this is not imported from automationutils.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

probably the same as bug 1125679

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Fix NameErrors in killAndGetStack in runreftest.py.

renamed `proc`s to `process`s, and added `printstatus` to import.

tried with a dummy timeout test case, and it seems that it killed the process correctly.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb91dc944519

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 8560397 [details] [diff] [review]
Fix NameErrors in killAndGetStack in runreftest.py.

Review of attachment 8560397 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Sorry about that, this is what happens when you write code using copy and paste. :-/

Comment 6

[Tooru Fujisawa [:arai]]

Thank you :D

https://hg.mozilla.org/integration/mozilla-inbound/rev/ea4f0984b731

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ea4f0984b731