1130413 - Remove unused nsITokenPasswordDialogs::GetPassword() function

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[:Cykesiopka]

The nsITokenPasswordDialogs::GetPassword() function is currently unused, and I suspect hasn't been used for quite a while.

I unfortunately don't think I have access to searching add-ons code, but it doesn't seem likely that anything uses this.

In any case, there are issues with the implementation such as using a .xul file instead of a nsIPromptService::PromptPassword() call, Bug 341418 etc. It would be nice to just get rid of this function.

Comment 1

[:Cykesiopka]

Attachment: bug1130413_rm-nsITokenPasswordDialogs-GetPassword()_v1.patch

Try looks OK so far: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd51981d38cb

Comment 2

[Dana Keeler (she/her) [:keeler]]

Comment on attachment 8570109 [details] [diff] [review]
bug1130413_rm-nsITokenPasswordDialogs-GetPassword()_v1.patch

Review of attachment 8570109 [details] [diff] [review]:
-----------------------------------------------------------------

JC, if you could review this, that would be great.

Comment 3

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 8570109 [details] [diff] [review]
bug1130413_rm-nsITokenPasswordDialogs-GetPassword()_v1.patch

Review of attachment 8570109 [details] [diff] [review]:
-----------------------------------------------------------------

r=jcj
Sorry it took me all weekend to get to this, but it looks/compiles/works OK for me.

Comment 4

[:Cykesiopka]

(In reply to J.C. Jones [:jcj] from comment #3)
> r=jcj
> Sorry it took me all weekend to get to this, but it looks/compiles/works OK
> for me.

Not a problem, thanks for the review!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e80498c60d0

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9238ec1ade3e

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9238ec1ade3e