1130537 - Reimplement js::SetPropertyIgnoringNamedGetter to follow ES6 draft rev 32 9.1.9 [[Set]]

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

Bug 1083211 fixed BaseProxyHandler::set, but a handful of proxies are using SetPropertyIgnoringNamedGetter which still does not resemble the spec at all.

The behavior should be just like 9.1.9 from step 4 to the end, with ownDesc passed in as an argument.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Update js::SetPropertyIgnoringNamedGetter to ES6 idioms

Comment 2

[Eric Faust [:efaust]]

Comment on attachment 8564262 [details] [diff] [review]
Update js::SetPropertyIgnoringNamedGetter to ES6 idioms

Review of attachment 8564262 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense. A nice simplification.

::: dom/base/nsGlobalWindow.cpp
@@ +916,5 @@
>    int32_t index = GetArrayIndexFromId(cx, id);
>    if (IsArrayIndex(index)) {
>      // Reject the set.  It's up to the caller to decide whether to throw a
>      // TypeError.  If the caller is strict mode JS code, it'll throw.
> +    return result.failReadOnly();

rebasing gunk, maybe? How did this compile before?

Comment 3

[Jason Orendorff [:jorendorff]]

Yes, that was rebasing gunk.

Comment 4

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b7a80ceeed2f

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b7a80ceeed2f