1130645 - Make sure XUL windows have a top-level APZC

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

ChromeProcessController::InitializeRoot doesn't work for XUL windows, since they don't have a root scrollframe. This means APZ doesn't work on Desktop unless the root scrollframe of a TabChild is an active scrollframe.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: patch

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/6849669e696e

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Backed out for Android robocop failures (rc1 and rc2 for API9, rc1 and rc3 for API11 which splits the tests more):

https://hg.mozilla.org/integration/mozilla-inbound/rev/54aff1390b16

The first failure in rc1 was:
TEST-UNEXPECTED-FAIL | testAxisLocking | PaintExpecter - blockUtilClear timeout
and the first failure in rc2 (API9) or rc3 (API11) was:
TEST-UNEXPECTED-FAIL | testPanCorrectness | PaintExpecter - blockUtilClear timeout

Comment 4

[Nigel Babu [:nigelb]]

Also busted refets

https://treeherder.mozilla.org/logviewer.html#?job_id=6639093&repo=mozilla-inbound

Comment 5

[David Anderson [:dvander] - inactive, e-mail if emergency]

Take two, preserving the behavior of container'd root frames that don't have a scroll frame.

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/84934f38ef76

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/84934f38ef76