1130663 - requestsync-manager API to allow for an immediate sync

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[James Burke [:jrburke]]

Feature request:

While testing, it would be nice if my certified app with requestsync-manager permissions was able to immediately trigger a sync for a given sync task. 

Then I could manually test what happens when the email app receives the setMessageHandler('request-sync') for certain testing scenarios, instead of waiting for an interval to pass.

While talking in IRC about it, :asuth also mentioned that this might also be useful for a case where a requestsync-manager app could allow the user to immediately trigger all of the sync tasks before dropping offline for a while.

Comment 1

[Andrea Marchesini [:baku]]

Makes definitely sense. Let me work on it.

Comment 2

[Andrea Marchesini [:baku]]

Attachment: runnow.patch

Comment 3

[Andrea Marchesini [:baku]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a6bfcbc61e5f
fully green on try.

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 8561507 [details] [diff] [review]
runnow.patch

Review of attachment 8561507 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/requestsync/RequestSyncService.jsm
@@ +551,5 @@
> +  managerRunTask: function(aTarget, aData, aPrincipal) {
> +    debug("runTask");
> +
> +    let task = null;
> +    let self = this;

It looks like you don't use |self| at all.

Comment 5

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f5128665af10

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f5128665af10

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/9b267d35a707