1130739 - Android crash in glGetInternalformativ on Mali-450 MP & 400 MP

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[[:philipp]]

This bug was filed from the Socorro interface and is 
report bp-7dfcbb8e-96af-4cb8-9bd4-211fc2150201.
=============================================================
more reports at https://crash-stats.mozilla.com/report/list?product=FennecAndroid&signature=glGetInternalformativ 

this crash seems to affect only devices with Mali-450 MP & 400 MP GPU, and from that subgroup predominantly CUBE U65GT tablets (75% of all crashes). it is the #37 top crasher on firefox 35 at the moment.
related sumo thread by an affected user: https://support.mozilla.org/en-US/questions/1045620

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

This code hasn't changed in quite some time: http://mxr.mozilla.org/mozilla-release/source/gfx/gl/SharedSurfaceEGL.cpp#197

I wonder what's going wrong there. Maybe a null mImage?

Comment 2

[Jamie Nicol [:jnicol]]

I believe this is just bug 1264505 but with a slightly different signature (different driver version?). Looks like we need to disable OES_EGL_image_external for Mali 450s as well as Mali 400s.

Comment 3

[Jamie Nicol [:jnicol]]

Attachment: Bug 1130739 - Disable OES_EGL_image_external on Mali 450.

Review commit: https://reviewboard.mozilla.org/r/80056/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80056/

Comment 4

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8793263 [details]
Bug 1130739 - Disable OES_EGL_image_external on Mali 450.

https://reviewboard.mozilla.org/r/80056/#review78756

Comment 5

[Jamie Nicol [:jnicol]]

https://treeherder.mozilla.org/#/jobs?repo=try&author=[e-mail]

Comment 6

[Jamie Nicol [:jnicol]]

Oops, that's a link to all my try pushes! Here's the right one: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a0d18185ec49e9f1f12c205abeab62eb84053c13

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/770a9b2e9ab6
Disable OES_EGL_image_external on Mali 450. r=eflores

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/770a9b2e9ab6

Comment 9

[Jamie Nicol [:jnicol]]

Comment on attachment 8793263 [details]
Bug 1130739 - Disable OES_EGL_image_external on Mali 450.

I think we should include this in 50 and 51

Approval Request Comment
[Feature/regressing bug #]: I believe this crash was introduced by bug 1144906. It's been around a while anyway.
[User impact if declined]: Guaranteed crash on youtube or other videos for Mali 450 devices
[Describe test coverage new/current, TreeHerder]: Workaround has been in place for Mali 400 devices for a couple of months (1264505)
[Risks and why]: Low - workaround already proven to work, just enabling it for another GPU model
[String/UUID change made/needed]: N/A

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8793263 [details]
Bug 1130739 - Disable OES_EGL_image_external on Mali 450.

Crash fix for a specific device type, Aurora51+, Beta50+

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c39eb11e4b5a

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c881ae64b145

Comment 13

[Chris Peterson [:cpeterson]]

Removing steps-wanted keyword because this bug has been resolved.