1130801 - test-buffer permanent failures

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Dave Townsend [:mossop]]

Looks like a regression on the platform side:

TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-buffer.testBufferMain | invalid encoding for Buffer.toString - "The given encoding 'invalid' is not supported." matches "function TypeError() {
    [native code]
}"
TEST-INFO | Traceback (most recent call last):
  File "resource://gre/modules/Promise-backend.js", line 688, in this.PromiseWalker.scheduleWalkerLoop/<
    DOMPromise.resolve().then(() => this.walkerLoop());
  File "resource://gre/modules/Promise-backend.js", line 746, in this.PromiseWalker.walkerLoop
    this.handlers.shift().process();
  File "resource://gre/modules/Promise-backend.js", line 867, in Handler.prototype.process
    nextValue = this.onResolve.call(undefined, nextValue);
  File "resource://extensions.modules.8f8fe57c-19ad-4a55-aa9e-18be307cbfce-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 522, in startMany/runNextTest/<
    self.start({test: test, onDone: runNextTest});
  File "resource://extensions.modules.8f8fe57c-19ad-4a55-aa9e-18be307cbfce-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 559, in start
    this.test.testFunction(this);
  File "resource://extensions.modules.8f8fe57c-19ad-4a55-aa9e-18be307cbfce-at-jetpack.commonjs.path/sdk/test.js", line 75, in null
    test(assert);
  File "resource://8f8fe57c-19ad-4a55-aa9e-18be307cbfce-at-jetpack/addon-sdk/tests/test-buffer.js", line 61, in exports.testBufferMain
    assert.throws(() => {
  File "resource://extensions.modules.8f8fe57c-19ad-4a55-aa9e-18be307cbfce-at-jetpack.commonjs.path/sdk/test/assert.js", line 309, in throws
    this.fail(failure);
  File "resource://extensions.modules.8f8fe57c-19ad-4a55-aa9e-18be307cbfce-at-jetpack.commonjs.path/sdk/test/assert.js", line 88, in fail
    this._log.fail(message);
  File "resource://extensions.modules.8f8fe57c-19ad-4a55-aa9e-18be307cbfce-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 104, in fail
    this.console.testMessage(false, false, this.test.name, message);
  File "resource://extensions.modules.8f8fe57c-19ad-4a55-aa9e-18be307cbfce-at-jetpack.commonjs.path/sdk/test/harness.js", line 543, in testMessage
    this.trace();


TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-buffer.testBufferWrite | invalid encoding with buffer write throws - "The given encoding 'invalid' is not supported." matches "function TypeError() {
    [native code]
}"
TEST-INFO | Traceback (most recent call last):
  File "resource://gre/modules/Promise-backend.js", line 688, in this.PromiseWalker.scheduleWalkerLoop/<
    DOMPromise.resolve().then(() => this.walkerLoop());
  File "resource://gre/modules/Promise-backend.js", line 746, in this.PromiseWalker.walkerLoop
    this.handlers.shift().process();
  File "resource://gre/modules/Promise-backend.js", line 867, in Handler.prototype.process
    nextValue = this.onResolve.call(undefined, nextValue);
  File "resource://extensions.modules.8f8fe57c-19ad-4a55-aa9e-18be307cbfce-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 522, in startMany/runNextTest/<
    self.start({test: test, onDone: runNextTest});
  File "resource://extensions.modules.8f8fe57c-19ad-4a55-aa9e-18be307cbfce-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 559, in start
    this.test.testFunction(this);
  File "resource://extensions.modules.8f8fe57c-19ad-4a55-aa9e-18be307cbfce-at-jetpack.commonjs.path/sdk/test.js", line 75, in null
    test(assert);
  File "resource://8f8fe57c-19ad-4a55-aa9e-18be307cbfce-at-jetpack/addon-sdk/tests/test-buffer.js", line 249, in exports.testBufferWrite
    assert.throws(() => {
  File "resource://extensions.modules.8f8fe57c-19ad-4a55-aa9e-18be307cbfce-at-jetpack.commonjs.path/sdk/test/assert.js", line 309, in throws
    this.fail(failure);
  File "resource://extensions.modules.8f8fe57c-19ad-4a55-aa9e-18be307cbfce-at-jetpack.commonjs.path/sdk/test/assert.js", line 88, in fail
    this._log.fail(message);
  File "resource://extensions.modules.8f8fe57c-19ad-4a55-aa9e-18be307cbfce-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 104, in fail
    this.console.testMessage(false, false, this.test.name, message);
  File "resource://extensions.modules.8f8fe57c-19ad-4a55-aa9e-18be307cbfce-at-jetpack.commonjs.path/sdk/test/harness.js", line 543, in testMessage
    this.trace();

Comment 1

[Dave Townsend [:mossop]]

Attachment: pull request

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 8561470 [details] [review]
pull request

Thanks!

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/5bf387020465c2f9711e7576262f77227dd2d87a
Bug 1130801: Test for the updated error type for buffers.

https://github.com/mozilla/addon-sdk/commit/a6973450d55d071a854119e9bad88358678fc1eb
Merge pull request #1859 from Mossop/bug1130801

Bug 1130801: Test for the updated error type for buffers. r=erikvold