Closed
Bug 1130849
Opened 11 years ago
Closed 11 years ago
Rename jsinfer files
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
| Tracking | Status | |
|---|---|---|
| firefox38 | --- | fixed |
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
Attachments
(1 file)
|
30.99 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
The jsinfer files are a good deal nicer with the recent refactorings and it would be good to rename them to vm/TypeInference{.h,.cpp,-inl.h} and finish this cleanup project. This patch also removes some includes that are redundant given other include chains.
Attachment #8561002 -
Flags: review?(jdemooij)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8561002 [details] [diff] [review]
patch
Review of attachment 8561002 [details] [diff] [review]:
-----------------------------------------------------------------
Cool.
::: js/src/jit/JitOptions.h
@@ +8,5 @@
> #define jit_JitOptions_h
>
> #include "jit/IonTypes.h"
> #include "js/TypeDecls.h"
> +#include "mozilla/Maybe.h"
This one should go before the others.
Attachment #8561002 -
Flags: review?(jdemooij) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
|
||
Comment 3•11 years ago
|
||
Assignee: nobody → bhackett1024
Status: NEW → RESOLVED
Closed: 11 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•