Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bhackett, Assigned: bhackett)

Tracking

Trunk
mozilla38
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox38 fixed)

Details

Attachments

(1 attachment)

Posted patch patchSplinter Review
The jsinfer files are a good deal nicer with the recent refactorings and it would be good to rename them to vm/TypeInference{.h,.cpp,-inl.h} and finish this cleanup project.  This patch also removes some includes that are redundant given other include chains.
Attachment #8561002 - Flags: review?(jdemooij)
Comment on attachment 8561002 [details] [diff] [review]
patch

Review of attachment 8561002 [details] [diff] [review]:
-----------------------------------------------------------------

Cool.

::: js/src/jit/JitOptions.h
@@ +8,5 @@
>  #define jit_JitOptions_h
>  
>  #include "jit/IonTypes.h"
>  #include "js/TypeDecls.h"
> +#include "mozilla/Maybe.h"

This one should go before the others.
Attachment #8561002 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/c4500f0d25cd
Assignee: nobody → bhackett1024
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.