Closed Bug 1130901 Opened 5 years ago Closed 5 years ago

Method patching can cause permission denied errors from call-watcher

Categories

(DevTools Graveyard :: Web Audio Editor, defect)

37 Branch
x86
macOS
defect
Not set

Tracking

(firefox38 fixed)

RESOLVED FIXED
Firefox 38
Tracking Status
firefox38 --- fixed

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(2 files)

Found using WAE with: http://webaudiotool.com/app/?patch=1C170F35-3D45-0777-0EFF-8F3DFE42A3F1

since we proxy patch AudioContext methods, calling them via `call` or `apply` in content produces a permission denied error, like on this line:

module.setAudioNode(this.audioContext[jsMethodName].call(this.audioContext, data.args));

This is due to the call-watcher actor, and will appear in the shader and canvas editor as well.
To clarify, this permission denied error breaks the entire functionality of the site with the tools open. Very very bad.
Attached image example
With the WAE tools open, and console, type in `(ctx = new AudioContext()).createOscillator.apply(ctx)` to see this.
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Tests pass for canvas and shader editor too. If there are any scenarios you think that are untested for these, let me know and I'll scope it out.
Attachment #8563125 - Flags: review?(vporof)
Attachment #8563125 - Flags: review?(vporof) → review+
https://hg.mozilla.org/integration/fx-team/rev/35d9b7e0d58a
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/35d9b7e0d58a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.