1130901 - Method patching can cause permission denied errors from call-watcher

Status: RESOLVED FIXED

(DevTools Graveyard :: Web Audio Editor, defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Found using WAE with: http://webaudiotool.com/app/?patch=1C170F35-3D45-0777-0EFF-8F3DFE42A3F1

since we proxy patch AudioContext methods, calling them via `call` or `apply` in content produces a permission denied error, like on this line:

module.setAudioNode(this.audioContext[jsMethodName].call(this.audioContext, data.args));

This is due to the call-watcher actor, and will appear in the shader and canvas editor as well.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

To clarify, this permission denied error breaks the entire functionality of the site with the tools open. Very very bad.

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: example

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

With the WAE tools open, and console, type in `(ctx = new AudioContext()).createOscillator.apply(ctx)` to see this.

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1130901-callwatcher.patch

Tests pass for canvas and shader editor too. If there are any scenarios you think that are untested for these, let me know and I'll scope it out.

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

 https://treeherder.mozilla.org/#/jobs?repo=try&revision=9473e242a866

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/35d9b7e0d58a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/35d9b7e0d58a